From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrVOB-0005b1-Vs for qemu-devel@nongnu.org; Thu, 20 Nov 2014 12:19:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrVO5-0005JS-SY for qemu-devel@nongnu.org; Thu, 20 Nov 2014 12:19:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrVO5-0005IM-LX for qemu-devel@nongnu.org; Thu, 20 Nov 2014 12:19:21 -0500 Message-ID: <546E228C.30603@redhat.com> Date: Thu, 20 Nov 2014 18:19:08 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-34-git-send-email-dgilbert@redhat.com> <54301FEE.10403@redhat.com> <20141120171243.GI5983@work-vm> In-Reply-To: <20141120171243.GI5983@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 33/47] Postcopy: Postcopy startup in migration thread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com On 20/11/2014 18:12, Dr. David Alan Gilbert wrote: > Trace added, and also moved as requested - was the request to move > it just to elimintate the other DPRINTF? Yes. >> > Also what is 2/3/4? Is this just for debugging or is it part of the >> > protocol? > Debug; they're very useful for matching the debug streams up, especially > when the timers on the two hosts are very different. > (I'm up for suggestions on how to mark the 2/3/4 for debug more clearly, > especially if it meant that it didn't make the ping (ne reqack) dedicated > to debug). > No problem, as long as it's clear to the guy matching the code against the debug output. Paolo