From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrWu2-0000fT-F0 for qemu-devel@nongnu.org; Thu, 20 Nov 2014 13:56:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrWtw-0000DQ-7M for qemu-devel@nongnu.org; Thu, 20 Nov 2014 13:56:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrWtv-0000D9-VU for qemu-devel@nongnu.org; Thu, 20 Nov 2014 13:56:20 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAKIuJ8Z014908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Nov 2014 13:56:19 -0500 Message-ID: <546E3950.6030407@redhat.com> Date: Thu, 20 Nov 2014 19:56:16 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416227466-29491-1-git-send-email-mreitz@redhat.com> <1416227466-29491-4-git-send-email-mreitz@redhat.com> <20141120183903.GI9266@noname.redhat.com> In-Reply-To: <20141120183903.GI9266@noname.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 3/3] iotests: Use -qmp-pretty in 067 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Paolo Bonzini , qemu-devel@nongnu.org, Stefan Hajnoczi On 20.11.2014 19:39, Kevin Wolf wrote: > Am 17.11.2014 um 13:31 hat Max Reitz geschrieben: >> 067 invokes query-block, resulting in a reference output with really >> long lines (which may pose a problem in email patches and always poses a >> problem when the output changes, because it is hard to see what has >> actually changed). Use -qmp-pretty to mitigate this issue. >> >> Signed-off-by: Max Reitz >> Reviewed-by: Eric Blake >> --- >> tests/qemu-iotests/067 | 2 +- >> tests/qemu-iotests/067.out | 779 +++++++++++++++++++++++++++++++++++++++++---- >> 2 files changed, 723 insertions(+), 58 deletions(-) > Hm, when I tried to rebase my query-block patch that adds cache > information, I noticed that I get a trailing space on every line of the > JSON dump, which isn't there in this patch. So 'cp 067.out.bad 067.out' > ended up changing every single line. :-/ > > Did you postprocess the reference output or do really get it without > trailing whitespace? Yes, I post-processed it, because you once complained about me sending patches with trailing whitespace. :-P As I wrote in some reply to some reply from Eric on some version of this patch, QEMU's pretty JSON formatter emits whitespace at the end of some lines. Max