From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrXe7-0001tr-PI for qemu-devel@nongnu.org; Thu, 20 Nov 2014 14:44:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrXe2-0001NY-Pe for qemu-devel@nongnu.org; Thu, 20 Nov 2014 14:44:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrXe2-0001NM-Hc for qemu-devel@nongnu.org; Thu, 20 Nov 2014 14:43:58 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAKJhuqS002510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Nov 2014 14:43:57 -0500 Message-ID: <546E447B.1060609@redhat.com> Date: Thu, 20 Nov 2014 12:43:55 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416227466-29491-1-git-send-email-mreitz@redhat.com> <1416227466-29491-4-git-send-email-mreitz@redhat.com> <20141120183903.GI9266@noname.redhat.com> <546E3950.6030407@redhat.com> In-Reply-To: <546E3950.6030407@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CKeH3ahiggoUhi4F6qkaah2D13UajuEBp" Subject: Re: [Qemu-devel] [PATCH v4 3/3] iotests: Use -qmp-pretty in 067 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Kevin Wolf Cc: Paolo Bonzini , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CKeH3ahiggoUhi4F6qkaah2D13UajuEBp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/20/2014 11:56 AM, Max Reitz wrote: > On 20.11.2014 19:39, Kevin Wolf wrote: >> Am 17.11.2014 um 13:31 hat Max Reitz geschrieben: >>> 067 invokes query-block, resulting in a reference output with really >>> long lines (which may pose a problem in email patches and always pose= s a >>> problem when the output changes, because it is hard to see what has >>> actually changed). Use -qmp-pretty to mitigate this issue. >>> >>> Signed-off-by: Max Reitz >>> Reviewed-by: Eric Blake >>> --- >>> tests/qemu-iotests/067 | 2 +- >>> tests/qemu-iotests/067.out | 779 >>> +++++++++++++++++++++++++++++++++++++++++---- >>> 2 files changed, 723 insertions(+), 58 deletions(-) >> Hm, when I tried to rebase my query-block patch that adds cache >> information, I noticed that I get a trailing space on every line of th= e >> JSON dump, which isn't there in this patch. So 'cp 067.out.bad 067.out= ' >> ended up changing every single line. :-/ >> >> Did you postprocess the reference output or do really get it without >> trailing whitespace? >=20 > Yes, I post-processed it, because you once complained about me sending > patches with trailing whitespace. :-P >=20 > As I wrote in some reply to some reply from Eric on some version of thi= s > patch, QEMU's pretty JSON formatter emits whitespace at the end of some= > lines. Trailing whitespace in canonical sources is annoying and should be avoided. But this file is about trailing whitespace in generated files (such as reference output) and which is therefore worth keeping, unless we fix the cause of the reference material having trailing whitespace in the first place. That way, we can regenerate the file from the same reference source, and won't have needless differences in trailing whitespace. Sounds like a bug in the JSON pretty formatter, but fixing it should be a separate series. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CKeH3ahiggoUhi4F6qkaah2D13UajuEBp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUbkR7AAoJEKeha0olJ0NquSgIAKGC6B0u0VJUPo75VdzR2nPM dHm2Q8ydvtCfdSgMzlaob5H/bm00wCwAoluV4M7vUHpAMCskXjsx/Ob0BuohH80w LqOZ+mVSv0ee2gxZRnFb6busoSjD68Ke0zcjUzWsz/Ks2uR2y/Yz4swbGFj+Gac2 UA5DADKYbPUp0jJsyPpNV50CvbExKJzdNx46yi/Zi8qMxWJrLnCpcZpmI83LVhH0 jsUxw3XxW3XRK6PBuGuvR3HsWu0jT17FUFAb0gHTnrYLdi46/HDPTdeH0uM4OSQB XCez+/mveaW2e3C44TDlQB5kh7RkmaknEqtzVYiX6r4VBWQCRIENvv4FMbSqSu0= =BFoq -----END PGP SIGNATURE----- --CKeH3ahiggoUhi4F6qkaah2D13UajuEBp--