From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xra8g-0004gd-9U for qemu-devel@nongnu.org; Thu, 20 Nov 2014 17:23:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xra8b-0000xb-Al for qemu-devel@nongnu.org; Thu, 20 Nov 2014 17:23:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xra8b-0000xV-2s for qemu-devel@nongnu.org; Thu, 20 Nov 2014 17:23:41 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAKMNebx004136 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Nov 2014 17:23:40 -0500 Message-ID: <546E69EB.4070306@redhat.com> Date: Thu, 20 Nov 2014 15:23:39 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416503198-17031-1-git-send-email-mreitz@redhat.com> <1416503198-17031-11-git-send-email-mreitz@redhat.com> In-Reply-To: <1416503198-17031-11-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AfIMPnHDEHDIOIrpXkM9HuQnXRH20jAmV" Subject: Re: [Qemu-devel] [PATCH v3 10/22] qcow2: refcount_order parameter for qcow2_create2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AfIMPnHDEHDIOIrpXkM9HuQnXRH20jAmV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/20/2014 10:06 AM, Max Reitz wrote: > Add a refcount_order parameter to qcow2_create2(), use that value for > the image header and for calculating the size required for > preallocation. >=20 > For now, always pass 4. >=20 > This addition requires changes to the calculation of the file size for > the "full" and "falloc" preallocation modes. That in turn is a nice > opportunity to add a command about that calculation not necessarily s/command/comment/ > being exact (and that being intentional). >=20 > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake But review still holds. :) > --- > block/qcow2.c | 46 +++++++++++++++++++++++++++++++++++----------- > 1 file changed, 35 insertions(+), 11 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AfIMPnHDEHDIOIrpXkM9HuQnXRH20jAmV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUbmnrAAoJEKeha0olJ0NqE3AIAKq3iorM9iNzAMlN0ZwYbvHF TVd2FRqsgmGylTGkT6Hi4yxpn9Sq4l7JzcorHoKGRbLahpsgVJCDDo0ql0IK2Z9H 7YemT1NvX2bZ37c8sHf3eGKnSX41VRCqJ2llq7tMtFIbZ3wm4xxHdfsPYzPOBL63 ZrEnxAzbTWT7cttGNMnegZSX7Mn4Gh/psIfSiL0YC7Fz01q/hWTZcYcUzRqHz/Xt sBUQe9/WGHOGiG93vyQf0ezAZKeUfe2i/MxlLOIc/bWL+WKZFyORw3ReHtMCIVPr uyPLnMKVtG5g4VgVpdUpfEY2X7lWIHZGm3N8SyKHABjPxNyYPT7ibm7DAlRTC9Y= =Wb06 -----END PGP SIGNATURE----- --AfIMPnHDEHDIOIrpXkM9HuQnXRH20jAmV--