From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XraED-00065A-TV for qemu-devel@nongnu.org; Thu, 20 Nov 2014 17:29:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XraE8-0002cu-Uw for qemu-devel@nongnu.org; Thu, 20 Nov 2014 17:29:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XraE8-0002ck-Np for qemu-devel@nongnu.org; Thu, 20 Nov 2014 17:29:24 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAKMTNwQ032282 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Nov 2014 17:29:23 -0500 Message-ID: <546E6B42.3030608@redhat.com> Date: Thu, 20 Nov 2014 15:29:22 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416503198-17031-1-git-send-email-mreitz@redhat.com> <1416503198-17031-14-git-send-email-mreitz@redhat.com> In-Reply-To: <1416503198-17031-14-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QieVNDBD07MMsKs0lsVA8jT5OvAS9Uswo" Subject: Re: [Qemu-devel] [PATCH v3 13/22] progress: Allow regressing progress List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QieVNDBD07MMsKs0lsVA8jT5OvAS9Uswo Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/20/2014 10:06 AM, Max Reitz wrote: > Progress may regress; this should be displayed correctly by > qemu_progress_print(). >=20 > Signed-off-by: Max Reitz > --- > util/qemu-progress.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake >=20 > diff --git a/util/qemu-progress.c b/util/qemu-progress.c > index 4ee5cd0..c0fb14d 100644 > --- a/util/qemu-progress.c > +++ b/util/qemu-progress.c > @@ -152,6 +152,7 @@ void qemu_progress_print(float delta, int max) > state.current =3D current; > =20 > if (current > (state.last_print + state.min_skip) || > + current < (state.last_print - state.min_skip) || > (current =3D=3D 100) || (current =3D=3D 0)) { Maybe we can drop the redundant () as long as we are touching this area of code? But not worth a respin. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QieVNDBD07MMsKs0lsVA8jT5OvAS9Uswo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUbmtCAAoJEKeha0olJ0NqYBYH/0w4T2goRiyRqKItvidyhhuu f2dQLumA0nNszZVtWr/A/1fb/6padXbji5bGGjoLP+PenASpeBvsJlvZWNQxtrEu SxoSfcau4uycO1uybI33ekokugbtme523z02HZ9PB8Oq7pGihYj5W+feNnkPEC28 uf+v0ggZQCJ4CskNeC2/WFaNbFmn+exp5pQavg9Mwf8S9QNQDyEpJf/vFOT6yqA6 PQOuXJ28DHjs8MqrfjUuOXFgAWQFWf/kxAptHl6gIYS2B+yB0BAs25HdF+qs2fvI o6QqO9t/75aGN5sTpIfddkT+pAr1diDWk9mAYGAaAZBZjJU/hr8oEJl6PTIJvcQ= =Mj0P -----END PGP SIGNATURE----- --QieVNDBD07MMsKs0lsVA8jT5OvAS9Uswo--