* [Qemu-devel] [PATCH] pcie: fix improper use of negative value
@ 2014-11-20 8:55 arei.gonglei
2014-11-21 0:01 ` [Qemu-devel] for 2.2: " Eric Blake
0 siblings, 1 reply; 3+ messages in thread
From: arei.gonglei @ 2014-11-20 8:55 UTC (permalink / raw)
To: qemu-devel; +Cc: Gonglei, mst
From: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 58455bd..2902f7d 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice *hotplug_dev,
/* the slot is electromechanically locked.
* This error is propagated up to qdev and then to HMP/QMP.
*/
- error_setg_errno(errp, -EBUSY, "slot is electromechanically locked");
+ error_setg_errno(errp, EBUSY, "slot is electromechanically locked");
}
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Qemu-devel] for 2.2: Re: [PATCH] pcie: fix improper use of negative value
2014-11-20 8:55 [Qemu-devel] [PATCH] pcie: fix improper use of negative value arei.gonglei
@ 2014-11-21 0:01 ` Eric Blake
2014-11-21 0:34 ` Gonglei
0 siblings, 1 reply; 3+ messages in thread
From: Eric Blake @ 2014-11-21 0:01 UTC (permalink / raw)
To: arei.gonglei, qemu-devel; +Cc: qemu-trivial, mst
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
On 11/20/2014 01:55 AM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
adding qemu-trivial in cc. This is a candidate for 2.2.
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 58455bd..2902f7d 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice *hotplug_dev,
> /* the slot is electromechanically locked.
> * This error is propagated up to qdev and then to HMP/QMP.
> */
> - error_setg_errno(errp, -EBUSY, "slot is electromechanically locked");
> + error_setg_errno(errp, EBUSY, "slot is electromechanically locked");
> }
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] for 2.2: Re: [PATCH] pcie: fix improper use of negative value
2014-11-21 0:01 ` [Qemu-devel] for 2.2: " Eric Blake
@ 2014-11-21 0:34 ` Gonglei
0 siblings, 0 replies; 3+ messages in thread
From: Gonglei @ 2014-11-21 0:34 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-trivial, qemu-devel@nongnu.org, mst@redhat.com
On 2014/11/21 8:01, Eric Blake wrote:
> On 11/20/2014 01:55 AM, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> ---
>> hw/pci/pcie.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> adding qemu-trivial in cc. This is a candidate for 2.2.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
Thanks. :)
Best regards,
-Gonglei
>>
>> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
>> index 58455bd..2902f7d 100644
>> --- a/hw/pci/pcie.c
>> +++ b/hw/pci/pcie.c
>> @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice *hotplug_dev,
>> /* the slot is electromechanically locked.
>> * This error is propagated up to qdev and then to HMP/QMP.
>> */
>> - error_setg_errno(errp, -EBUSY, "slot is electromechanically locked");
>> + error_setg_errno(errp, EBUSY, "slot is electromechanically locked");
>> }
>> }
>>
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-21 0:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-20 8:55 [Qemu-devel] [PATCH] pcie: fix improper use of negative value arei.gonglei
2014-11-21 0:01 ` [Qemu-devel] for 2.2: " Eric Blake
2014-11-21 0:34 ` Gonglei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).