Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation

[Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>]

On 11/20/2014 07:18 PM, Kevin Wolf wrote:
> Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben:
>> On Wed, 19 Nov 2014 14:40:07 +0000
>> Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>>> On 19 November 2014 14:01, Ekaterina Tumanova
>>> <tumanova@linux.vnet.ibm.com> wrote:
>>>> Signed-off-by: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
>>>
>>> Could you give the compiler error/warning message, please
>>> (and the compiler version)?
>>>
>>> These changes look sensible but it's not clear to me why
>>> the current code would cause a compilation failure or why
>>> that would be specific to i386...
>>
>> This patch is referring to Kate's patch set "[PATCH v2 0/6] Geometry
>> and blocksize support for backing devices", which did not compile on
>> i386 (see <546C8161.10100@de.ibm.com>).
>
> Where does it need to be squashed in? We want to keep the tree
> bisectable, so breaking the build and then fixing it at the end of the
> series isn't an option.
>
> Kevin
>

This is just a small -in-reply-to patch to Christian's note, fixing the
patch set compilation on i386.
It should be squashed into the last patch in a series:
"[PATCH v2 6/6] geometry: Target specific hook for s390x in geometry
guessing".
I just don't want to send a new version before receiving any substantial
comments.

Kate.