From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrkjJ-0003uD-Nn for qemu-devel@nongnu.org; Fri, 21 Nov 2014 04:42:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrkjB-0001Df-UZ for qemu-devel@nongnu.org; Fri, 21 Nov 2014 04:42:17 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:49210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrkjB-0001DE-Ka for qemu-devel@nongnu.org; Fri, 21 Nov 2014 04:42:09 -0500 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 21 Nov 2014 09:42:07 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id DB98A1B08049 for ; Fri, 21 Nov 2014 09:42:17 +0000 (GMT) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sAL9g5GA4653534 for ; Fri, 21 Nov 2014 09:42:05 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sAL9g3GK018174 for ; Fri, 21 Nov 2014 02:42:04 -0700 Message-ID: <546F08EA.9010805@linux.vnet.ibm.com> Date: Fri, 21 Nov 2014 12:42:02 +0300 From: Ekaterina Tumanova MIME-Version: 1.0 References: <546C8161.10100@de.ibm.com> <1416405716-21624-1-git-send-email-tumanova@linux.vnet.ibm.com> <20141119160406.7b8e0dbd.cornelia.huck@de.ibm.com> <20141120161830.GE9266@noname.redhat.com> In-Reply-To: <20141120161830.GE9266@noname.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Cornelia Huck Cc: Peter Maydell , Christian Borntraeger , Markus Armbruster , Public KVM Mailing List , Viktor Mihajlovski , David Hildenbrand , Stefan Hajnoczi , Paolo Bonzini On 11/20/2014 07:18 PM, Kevin Wolf wrote: > Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben: >> On Wed, 19 Nov 2014 14:40:07 +0000 >> Peter Maydell wrote: >> >>> On 19 November 2014 14:01, Ekaterina Tumanova >>> wrote: >>>> Signed-off-by: Ekaterina Tumanova >>> >>> Could you give the compiler error/warning message, please >>> (and the compiler version)? >>> >>> These changes look sensible but it's not clear to me why >>> the current code would cause a compilation failure or why >>> that would be specific to i386... >> >> This patch is referring to Kate's patch set "[PATCH v2 0/6] Geometry >> and blocksize support for backing devices", which did not compile on >> i386 (see <546C8161.10100@de.ibm.com>). > > Where does it need to be squashed in? We want to keep the tree > bisectable, so breaking the build and then fixing it at the end of the > series isn't an option. > > Kevin > This is just a small -in-reply-to patch to Christian's note, fixing the patch set compilation on i386. It should be squashed into the last patch in a series: "[PATCH v2 6/6] geometry: Target specific hook for s390x in geometry guessing". I just don't want to send a new version before receiving any substantial comments. Kate.