From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrmrp-0006Xx-5X for qemu-devel@nongnu.org; Fri, 21 Nov 2014 06:59:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xrmrf-0003Dc-R4 for qemu-devel@nongnu.org; Fri, 21 Nov 2014 06:59:13 -0500 Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:53853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrmrf-0003DR-KI for qemu-devel@nongnu.org; Fri, 21 Nov 2014 06:59:03 -0500 Received: by mail-wg0-f52.google.com with SMTP id a1so6324768wgh.25 for ; Fri, 21 Nov 2014 03:59:00 -0800 (PST) Sender: Paolo Bonzini Message-ID: <546F2900.7040000@redhat.com> Date: Fri, 21 Nov 2014 12:58:56 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1416566940-4430-1-git-send-email-stefanha@redhat.com> <1416566940-4430-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1416566940-4430-5-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] blockdev: check for BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , mreitz@redhat.com On 21/11/2014 11:49, Stefan Hajnoczi wrote: > The BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT op blocker exists but was never > used! Let's fix that so external snapshot can be blocked. The patch is about internal snapshots tho. :) Paolo > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/blockdev.c b/blockdev.c > index 90cb33d..d63bb7f 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -1236,6 +1236,10 @@ static void internal_snapshot_prepare(BlkTransactionState *common, > return; > } > > + if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_INTERNAL_SNAPSHOT, errp)) { > + return; > + } > + > if (bdrv_is_read_only(bs)) { > error_set(errp, QERR_DEVICE_IS_READ_ONLY, device); > return; >