qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] blockdev: update outdated qmp_transaction() comments
Date: Fri, 21 Nov 2014 14:30:18 +0100	[thread overview]
Message-ID: <546F3E6A.8070106@redhat.com> (raw)
In-Reply-To: <546F3C8C.2010105@redhat.com>

On 2014-11-21 at 14:22, Max Reitz wrote:
> On 2014-11-21 at 11:48, Stefan Hajnoczi wrote:
>> Originally the transaction QMP command was just for taking snapshots.
>> The command became more general when drive-backup and abort were added.
>>
>> It is more accurate to say the command is about performing operations on
>> an atomic group than to say it is about snapshots.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>>   blockdev.c | 16 ++++++----------
>>   1 file changed, 6 insertions(+), 10 deletions(-)
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>

Oh, I forgot to note: The patch is fine and it applies cleanly to 
master. But there is a contextual conflict when applying it on top of 
your previous series.

Max

  reply	other threads:[~2014-11-21 13:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-21 10:48 [Qemu-devel] [PATCH 0/4] blockdev: support dataplane in QMP 'transaction' command Stefan Hajnoczi
2014-11-21 10:48 ` [Qemu-devel] [PATCH 1/4] blockdev: update outdated qmp_transaction() comments Stefan Hajnoczi
2014-11-21 13:22   ` Max Reitz
2014-11-21 13:30     ` Max Reitz [this message]
2014-11-21 10:48 ` [Qemu-devel] [PATCH 2/4] blockdev: drop unnecessary DriveBackupState field assignment Stefan Hajnoczi
2014-11-21 13:25   ` Max Reitz
2014-11-21 10:48 ` [Qemu-devel] [PATCH 3/4] blockdev: acquire AioContext in QMP 'transaction' actions Stefan Hajnoczi
2014-11-21 13:51   ` Max Reitz
2014-11-24 13:57     ` Stefan Hajnoczi
2014-11-21 10:49 ` [Qemu-devel] [PATCH 4/4] blockdev: check for BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT Stefan Hajnoczi
2014-11-21 11:58   ` Paolo Bonzini
2014-11-24 13:58     ` Stefan Hajnoczi
2014-11-24 16:13   ` Max Reitz
2014-11-26 16:41 ` [Qemu-devel] [PATCH 0/4] blockdev: support dataplane in QMP 'transaction' command Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546F3E6A.8070106@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).