From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XroI8-0006YZ-1c for qemu-devel@nongnu.org; Fri, 21 Nov 2014 08:30:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XroI1-0005KM-T1 for qemu-devel@nongnu.org; Fri, 21 Nov 2014 08:30:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XroI1-0005K9-MU for qemu-devel@nongnu.org; Fri, 21 Nov 2014 08:30:21 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sALDUKou027916 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 21 Nov 2014 08:30:21 -0500 Message-ID: <546F3E6A.8070106@redhat.com> Date: Fri, 21 Nov 2014 14:30:18 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416566940-4430-1-git-send-email-stefanha@redhat.com> <1416566940-4430-2-git-send-email-stefanha@redhat.com> <546F3C8C.2010105@redhat.com> In-Reply-To: <546F3C8C.2010105@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] blockdev: update outdated qmp_transaction() comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini On 2014-11-21 at 14:22, Max Reitz wrote: > On 2014-11-21 at 11:48, Stefan Hajnoczi wrote: >> Originally the transaction QMP command was just for taking snapshots. >> The command became more general when drive-backup and abort were added. >> >> It is more accurate to say the command is about performing operations on >> an atomic group than to say it is about snapshots. >> >> Signed-off-by: Stefan Hajnoczi >> --- >> blockdev.c | 16 ++++++---------- >> 1 file changed, 6 insertions(+), 10 deletions(-) > > Reviewed-by: Max Reitz Oh, I forgot to note: The patch is fine and it applies cleanly to master. But there is a contextual conflict when applying it on top of your previous series. Max