From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrqG4-0002le-7P for qemu-devel@nongnu.org; Fri, 21 Nov 2014 10:36:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrqFz-0008EA-Aq for qemu-devel@nongnu.org; Fri, 21 Nov 2014 10:36:28 -0500 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:52505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrqFz-0008E4-3j for qemu-devel@nongnu.org; Fri, 21 Nov 2014 10:36:23 -0500 Received: by mail-wi0-f180.google.com with SMTP id n3so9320725wiv.1 for ; Fri, 21 Nov 2014 07:36:22 -0800 (PST) Sender: Richard Henderson Message-ID: <546F5A70.9070802@twiddle.net> Date: Fri, 21 Nov 2014 16:29:52 +0100 From: Richard Henderson MIME-Version: 1.0 References: <1416583914-15891-1-git-send-email-kbastian@mail.uni-paderborn.de> <1416583914-15891-5-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1416583914-15891-5-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 4/4] target-tricore: Add instructions of RCR opcode format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 11/21/2014 04:31 PM, Bastian Koppelmann wrote: > Add instructions of RCR opcode format. > Add helper for madd32/64_ssov and madd32/64_suov. > Add helper for msub32/64_ssov and msub32/64_suov. > Add microcode generator function madd/msub for 32bit and 64bit, which calculate a mul and a add/sub. > OPC2_32_RCR_MSUB_U_32 -> OPC2_32_RCR_MSUB_U_32. > > Signed-off-by: Bastian Koppelmann > --- > v3 -> v4: > - helper madd64_ssov/suov and msub64_ssov/suov now use 64 bit arithmetic for the add. (Thanks alot, Richard!) Reviewed-by: Richard Henderson r~