From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qjson: Drop trailing space for pretty formatting
Date: Fri, 21 Nov 2014 09:07:35 -0700 [thread overview]
Message-ID: <546F6347.5030808@redhat.com> (raw)
In-Reply-To: <1416562199-13731-1-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
On 11/21/2014 02:29 AM, Max Reitz wrote:
> For the pretty formatting, the functions converting QDicts and QLists to
> JSON should not print a space after the comma separating objects,
> because a newline will emitted immediately afterwards, making the
> whitespace superfluous.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> qobject/qjson.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
prev parent reply other threads:[~2014-11-21 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 9:29 [Qemu-devel] [PATCH] qjson: Drop trailing space for pretty formatting Max Reitz
2014-11-21 12:36 ` Kevin Wolf
2014-11-21 16:07 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546F6347.5030808@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).