From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrr5s-0002ha-FY for qemu-devel@nongnu.org; Fri, 21 Nov 2014 11:30:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xrr5o-0001JB-0S for qemu-devel@nongnu.org; Fri, 21 Nov 2014 11:30:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrr5n-0001Ir-Qa for qemu-devel@nongnu.org; Fri, 21 Nov 2014 11:29:55 -0500 Message-ID: <546F6880.3080106@redhat.com> Date: Fri, 21 Nov 2014 09:29:52 -0700 From: Eric Blake MIME-Version: 1.0 References: <1406688906-6072-1-git-send-email-cyliu@suse.com> <20141121162505.GF3956@noname.redhat.com> In-Reply-To: <20141121162505.GF3956@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7LpI9m2q47tBmrMsvmrVUBOscCE3sgDBg" Subject: Re: [Qemu-devel] [RESEND PATCH V3] qemu-img info: show nocow info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Chunyan Liu Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7LpI9m2q47tBmrMsvmrVUBOscCE3sgDBg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/21/2014 09:25 AM, Kevin Wolf wrote: > Am 30.07.2014 um 04:55 hat Chunyan Liu geschrieben: >> Add nocow info in 'qemu-img info' output to show whether the file >> currently has NOCOW flag set or not. >> >> Signed-off-by: Chunyan Liu >> Reviewed-by: Eric Blake >> --- >> Resend for QEMU 2.2. Change json version comment. Add Reviewed-by. >> >> block/qapi.c | 25 +++++++++++++++++++++++++ >> qapi/block-core.json | 5 ++++- >> 2 files changed, 29 insertions(+), 1 deletion(-) >=20 > Unfortunately, I have never been CCed on this patch and I saw the code > it added only now. I think it doesn't work correctly and has the wrong > design, so I would prefer to revert it for 2.2 rather than making a bad= > API stable. Even though I reviewed the original, you make some valid points, and I can agree to a revert to avoid baking in a mistake. >> @@ -126,7 +128,8 @@ >> '*backing-filename': 'str', '*full-backing-filename': 'str= ', >> '*backing-filename-format': 'str', '*snapshots': ['Snapsho= tInfo'], >> '*backing-image': 'ImageInfo', >> - '*format-specific': 'ImageInfoSpecific' } } >> + '*format-specific': 'ImageInfoSpecific', >> + '*nocow': 'bool' } } >=20 > As this field makes only sense for raw-posix, it should be moved to > ImageInfoSpecific. ("format-specific" is also an unfortunate misnomer, > it should be "driver-specific", but it's too late to fix that.) Yes, that alone is a compelling reason to back this out and get the interface right. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7LpI9m2q47tBmrMsvmrVUBOscCE3sgDBg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUb2iAAAoJEKeha0olJ0Nq11gH/jXXB/SnBs6hH/M8qi1IQUXl 6YWC8mPh7lL8RMRXyo6UpuvPdFWI/KqqebVAVEH5ZSpopmHt83lcYQsk5lbR3v+6 Krr+6f0gQ0gH5m+SVc500jYRywp6SGEw+AOUiRLwC2KCBcC9rL2Z2R2/0uARBgEc KXk23N50wTwguflRL4NWXK0AJv7iE60uKZxXwzhBRiesarsi53VYQZ3tgq0fZwTs Qk1wg+ezkH7fZK49HaOMFV79G3nrwb3FBoETd7CG0Khwn9dxGmfoZohOKXEpAqyy QD+jciafR9pjYTDOM576RLppL40BWbk4+VvitlP0nRUm20PkuzfU9SURAp5AQxg= =Gi3g -----END PGP SIGNATURE----- --7LpI9m2q47tBmrMsvmrVUBOscCE3sgDBg--