From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: cyliu@suse.com, stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.2] Revert "qemu-img info: show nocow info"
Date: Fri, 21 Nov 2014 10:08:10 -0700 [thread overview]
Message-ID: <546F717A.90801@redhat.com> (raw)
In-Reply-To: <1416589530-10264-1-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
On 11/21/2014 10:05 AM, Kevin Wolf wrote:
> This reverts commit 000c4dfff4d7686e2fba3066a477a1290ed60622.
>
> The main reason for reverting this commit before the 2.2 release is that
> it adds a QAPI interface that we don't want to keep: The 'nocow' flag
> doesn't generally make sense for block nodes, but only for the raw-posix
> driver. It should therefore be part of ImageInfoSpecific rather than
> ImageInfo.
>
> The commit contains more problems, but unlike the API stability issue
> they wouldn't justify reverting it.
>
> Conflicts:
> block/qapi.c
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qapi.c | 26 --------------------------
> qapi/block-core.json | 5 +----
> 2 files changed, 1 insertion(+), 30 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-11-21 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 17:05 [Qemu-devel] [PATCH for-2.2] Revert "qemu-img info: show nocow info" Kevin Wolf
2014-11-21 17:08 ` Eric Blake [this message]
2014-11-24 12:02 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546F717A.90801@redhat.com \
--to=eblake@redhat.com \
--cc=cyliu@suse.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).