From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrrgu-0007ue-Ge for qemu-devel@nongnu.org; Fri, 21 Nov 2014 12:08:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xrrgp-0005S2-J9 for qemu-devel@nongnu.org; Fri, 21 Nov 2014 12:08:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrrgp-0005Ru-BN for qemu-devel@nongnu.org; Fri, 21 Nov 2014 12:08:11 -0500 Message-ID: <546F717A.90801@redhat.com> Date: Fri, 21 Nov 2014 10:08:10 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416589530-10264-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1416589530-10264-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fBSaF130adCqF9TclOvELrF18kLPXncR6" Subject: Re: [Qemu-devel] [PATCH for-2.2] Revert "qemu-img info: show nocow info" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: cyliu@suse.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fBSaF130adCqF9TclOvELrF18kLPXncR6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/21/2014 10:05 AM, Kevin Wolf wrote: > This reverts commit 000c4dfff4d7686e2fba3066a477a1290ed60622. >=20 > The main reason for reverting this commit before the 2.2 release is tha= t > it adds a QAPI interface that we don't want to keep: The 'nocow' flag > doesn't generally make sense for block nodes, but only for the raw-posi= x > driver. It should therefore be part of ImageInfoSpecific rather than > ImageInfo. >=20 > The commit contains more problems, but unlike the API stability issue > they wouldn't justify reverting it. >=20 > Conflicts: > block/qapi.c >=20 > Signed-off-by: Kevin Wolf > --- > block/qapi.c | 26 -------------------------- > qapi/block-core.json | 5 +---- > 2 files changed, 1 insertion(+), 30 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fBSaF130adCqF9TclOvELrF18kLPXncR6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUb3F6AAoJEKeha0olJ0Nq2skH/iZUkT1MYC/YxGl3AIxzPhdQ JzSYRBqPnlEVJ1flNqGpuejGiB2B2EsVTc+ZwvQKdoxKz05uB58PLRr0YBTTLBvh m9ZMZe7fUYctKCKMD9N0EFQNUfSmQBZA03nO7YrWvngUChrpACvNvEk8UmAqPRBx CoCmAZUCRxJpl1pz8cv+/qnfy7EpjcsXfm7K7uAEUBJxTEhtDJht1SvoIqHVL0Rn MejGFIW8jwfME6QjCOxDKSyFkcD3xYL1/QNvxsWOr+l667IV/sARPhS3SbXCeesm ooaOkWwSEHrfVTAfQNhoqR2O6za5wU1sdEH6jRM6cngzKIoUvQkRBS7skE9iVAA= =lbf3 -----END PGP SIGNATURE----- --fBSaF130adCqF9TclOvELrF18kLPXncR6--