From: Eric Blake <eblake@redhat.com>
To: Jiahui Cen <cenjiahui@huawei.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org,
"Michael S. Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
fangying1@huawei.com, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH v4 1/7] qapi/block-core: Add retry option for error action
Date: Wed, 27 Jan 2021 11:16:43 -0600 [thread overview]
Message-ID: <5470cc4f-5bcf-74d2-4e93-4de0b3ab6afa@redhat.com> (raw)
In-Reply-To: <20201215123011.4048-2-cenjiahui@huawei.com>
On 12/15/20 6:30 AM, Jiahui Cen wrote:
> Add a new error action 'retry' to support retry on errors.
>
> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
> Signed-off-by: Ying Fang <fangying1@huawei.com>
> ---
> blockdev.c | 2 ++
> qapi/block-core.json | 4 ++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
> +++ b/qapi/block-core.json
> @@ -1146,7 +1146,7 @@
> # Since: 1.3
> ##
> { 'enum': 'BlockdevOnError',
> - 'data': ['report', 'ignore', 'enospc', 'stop', 'auto'] }
> + 'data': ['report', 'ignore', 'enospc', 'stop', 'auto', 'retry'] }
Missing a documentation line that 'retry' was added in 6.0.
>
> ##
> # @MirrorSyncMode:
> @@ -4770,7 +4770,7 @@
> # Since: 2.1
> ##
> { 'enum': 'BlockErrorAction',
> - 'data': [ 'ignore', 'report', 'stop' ] }
> + 'data': [ 'ignore', 'report', 'stop', 'retry' ] }
Likewise.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-01-27 17:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 12:30 [PATCH v4 0/7] block: Add retry for werror=/rerror= mechanism Jiahui Cen
2020-12-15 12:30 ` [PATCH v4 1/7] qapi/block-core: Add retry option for error action Jiahui Cen
2021-01-27 17:16 ` Eric Blake [this message]
2020-12-15 12:30 ` [PATCH v4 2/7] block-backend: Introduce retry timer Jiahui Cen
2020-12-15 12:30 ` [PATCH v4 3/7] block-backend: Add device specific retry callback Jiahui Cen
2020-12-15 12:30 ` [PATCH v4 4/7] block-backend: Enable retry action on errors Jiahui Cen
2020-12-15 12:30 ` [PATCH v4 5/7] block-backend: Add timeout support for retry Jiahui Cen
2020-12-15 12:30 ` [PATCH v4 6/7] block: Add error retry param setting Jiahui Cen
2020-12-15 12:30 ` [PATCH v4 7/7] virtio_blk: Add support for retry on errors Jiahui Cen
2020-12-21 7:57 ` [PATCH v4 0/7] block: Add retry for werror=/rerror= mechanism Jiahui Cen
2021-01-05 9:33 ` Ping: " Jiahui Cen
2021-01-25 3:23 ` Ying Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5470cc4f-5bcf-74d2-4e93-4de0b3ab6afa@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=cenjiahui@huawei.com \
--cc=fangying1@huawei.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).