Re: [Qemu-devel] [Qemu-ppc] [PATCH V2 0/3] spapr: Fix stale HTAB during live migration

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 11/17/2014 11:26 PM, Alexander Graf wrote:
> 
> 
> 
>> Am 17.11.2014 um 05:12 schrieb Samuel Mendoza-Jonas <sam.mj@au1.ibm.com>:
>>
>> If a spapr guest reboots during a live migration, the guest HTAB on the
>> destination is not updated properly, usually resulting in a kernel panic.
>>
>> This is a (delayed!) follow up to my previous patch including a fix
>> for TCG guests as well as KVM.
>>
>> Changes from V1:
>> - Split out overflow fix into separate patch
>> - Removed unnecessary locks (relevant operations occur under BQL)
>> - TCG: Set HTAB dirty instead of resetting migration state
>> - Minor style fixes
> 
> Looks great to me, but I would like to get a reviewed-by from Alexey as well ;)

Looks good to me too.

Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>


> 
> 
> Alex
> 
>>
>> Samuel Mendoza-Jonas (3):
>>  spapr: Fix stale HTAB during live migration (KVM)
>>  spapr: Fix integer overflow during migration (TCG)
>>  spapr: Fix stale HTAB during live migration (TCG)
>>
>> hw/ppc/spapr.c         | 60 +++++++++++++++++++++++++++++++++++++++++++-------
>> include/hw/ppc/spapr.h |  1 +
>> 2 files changed, 53 insertions(+), 8 deletions(-)
>>
>> -- 
>> 1.9.3
>>
>>


-- 
Alexey