From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsnRk-0006Se-6s for qemu-devel@nongnu.org; Mon, 24 Nov 2014 01:48:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XsnRd-0001w0-Tx for qemu-devel@nongnu.org; Mon, 24 Nov 2014 01:48:28 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:40603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsnRd-0001vq-Nx for qemu-devel@nongnu.org; Mon, 24 Nov 2014 01:48:21 -0500 Received: by mail-pa0-f41.google.com with SMTP id rd3so9008332pab.0 for ; Sun, 23 Nov 2014 22:48:20 -0800 (PST) Message-ID: <5472D4AC.5010503@ozlabs.ru> Date: Mon, 24 Nov 2014 17:48:12 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1416197550-19708-1-git-send-email-sam.mj@au1.ibm.com> <5F05F64E-9AF8-4D05-975C-FDD091CAAC41@suse.de> In-Reply-To: <5F05F64E-9AF8-4D05-975C-FDD091CAAC41@suse.de> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH V2 0/3] spapr: Fix stale HTAB during live migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Samuel Mendoza-Jonas Cc: "qemu-ppc@nongnu.org" , "qemu-devel@nongnu.org" On 11/17/2014 11:26 PM, Alexander Graf wrote: > > > >> Am 17.11.2014 um 05:12 schrieb Samuel Mendoza-Jonas : >> >> If a spapr guest reboots during a live migration, the guest HTAB on the >> destination is not updated properly, usually resulting in a kernel panic. >> >> This is a (delayed!) follow up to my previous patch including a fix >> for TCG guests as well as KVM. >> >> Changes from V1: >> - Split out overflow fix into separate patch >> - Removed unnecessary locks (relevant operations occur under BQL) >> - TCG: Set HTAB dirty instead of resetting migration state >> - Minor style fixes > > Looks great to me, but I would like to get a reviewed-by from Alexey as well ;) Looks good to me too. Reviewed-by: Alexey Kardashevskiy > > > Alex > >> >> Samuel Mendoza-Jonas (3): >> spapr: Fix stale HTAB during live migration (KVM) >> spapr: Fix integer overflow during migration (TCG) >> spapr: Fix stale HTAB during live migration (TCG) >> >> hw/ppc/spapr.c | 60 +++++++++++++++++++++++++++++++++++++++++++------- >> include/hw/ppc/spapr.h | 1 + >> 2 files changed, 53 insertions(+), 8 deletions(-) >> >> -- >> 1.9.3 >> >> -- Alexey