From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsqFo-0004Uf-8b for qemu-devel@nongnu.org; Mon, 24 Nov 2014 04:48:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XsqFh-0001gR-TI for qemu-devel@nongnu.org; Mon, 24 Nov 2014 04:48:20 -0500 Message-ID: <5472FEDB.5060609@suse.de> Date: Mon, 24 Nov 2014 10:48:11 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1416197550-19708-1-git-send-email-sam.mj@au1.ibm.com> <5F05F64E-9AF8-4D05-975C-FDD091CAAC41@suse.de> <5472D4AC.5010503@ozlabs.ru> In-Reply-To: <5472D4AC.5010503@ozlabs.ru> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH V2 0/3] spapr: Fix stale HTAB during live migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , Samuel Mendoza-Jonas Cc: "qemu-ppc@nongnu.org" , "qemu-devel@nongnu.org" On 24.11.14 07:48, Alexey Kardashevskiy wrote: > On 11/17/2014 11:26 PM, Alexander Graf wrote: >> >> >> >>> Am 17.11.2014 um 05:12 schrieb Samuel Mendoza-Jonas : >>> >>> If a spapr guest reboots during a live migration, the guest HTAB on the >>> destination is not updated properly, usually resulting in a kernel panic. >>> >>> This is a (delayed!) follow up to my previous patch including a fix >>> for TCG guests as well as KVM. >>> >>> Changes from V1: >>> - Split out overflow fix into separate patch >>> - Removed unnecessary locks (relevant operations occur under BQL) >>> - TCG: Set HTAB dirty instead of resetting migration state >>> - Minor style fixes >> >> Looks great to me, but I would like to get a reviewed-by from Alexey as well ;) > > Looks good to me too. > > Reviewed-by: Alexey Kardashevskiy Thanks, applied all to ppc-next-2.3. Alex