From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsrCE-0003Q2-2Y for qemu-devel@nongnu.org; Mon, 24 Nov 2014 05:48:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XsrC5-0001BU-T9 for qemu-devel@nongnu.org; Mon, 24 Nov 2014 05:48:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsrC5-0001B5-LZ for qemu-devel@nongnu.org; Mon, 24 Nov 2014 05:48:33 -0500 Message-ID: <54730CF5.9060507@redhat.com> Date: Mon, 24 Nov 2014 11:48:21 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1415286601-30715-1-git-send-email-ming.lei@canonical.com> <1415286601-30715-3-git-send-email-ming.lei@canonical.com> <546B525F.3070001@redhat.com> <5472FFEA.2080806@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ming Lei Cc: Kevin Wolf , Peter Maydell , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel , Stefan Hajnoczi On 24/11/2014 11:11, Ming Lei wrote: > Yes, the above change need the corresponding comment, but this > patch needn't since the 1st case won't reach here, :-) I'm not sure I follow, but you can send v4 with a clearer comment I guess. :) Paolo