From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XswGz-0007oL-0O for qemu-devel@nongnu.org; Mon, 24 Nov 2014 11:14:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XswGs-0001e4-Sp for qemu-devel@nongnu.org; Mon, 24 Nov 2014 11:13:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XswGs-0001ds-MP for qemu-devel@nongnu.org; Mon, 24 Nov 2014 11:13:50 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAOGDnwv008690 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 24 Nov 2014 11:13:50 -0500 Message-ID: <5473593B.30900@redhat.com> Date: Mon, 24 Nov 2014 17:13:47 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416566940-4430-1-git-send-email-stefanha@redhat.com> <1416566940-4430-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1416566940-4430-5-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] blockdev: check for BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini On 2014-11-21 at 11:49, Stefan Hajnoczi wrote: > The BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT op blocker exists but was never > used! Let's fix that so external snapshot can be blocked. > > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 4 ++++ > 1 file changed, 4 insertions(+) With commit message and title fixed (there are three instances of /external/i): Reviewed-by: Max Reitz