From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41016)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtCFK-0002xW-Qc
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 04:17:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtCFE-0002YM-MH
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 04:17:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60577)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtCFE-0002YF-Eg
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 04:17:12 -0500
Message-ID: <54744912.4020502@redhat.com>
Date: Tue, 25 Nov 2014 10:17:06 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1414478736-30064-1-git-send-email-famz@redhat.com>
	<1414478736-30064-3-git-send-email-famz@redhat.com>
In-Reply-To: <1414478736-30064-3-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] tests/Makefile: Add check-block to
 make check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>

On 2014-10-28 at 07:45, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   tests/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 16f0e4c..f430b18 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -463,7 +463,7 @@ check-qapi-schema: $(patsubst %,check-%, $(check-qapi-schema-y))
>   check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS))
>   check-unit: $(patsubst %,check-%, $(check-unit-y))
>   check-block: $(patsubst %,check-%, $(check-block-y))
> -check: check-qapi-schema check-unit check-qtest
> +check: check-qapi-schema check-unit check-qtest check-block
>   check-clean:
>   	$(MAKE) -C tests/tcg clean
>   	rm -rf $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y)

Even regardless of patch 1:

Reviewed-by: Max Reitz <mreitz@redhat.com>

But we must fix 039 first (I remember some other test failing sometimes, 
but I can't remember which).