From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44447)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtCT1-0000D2-1f
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 04:31:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtCSv-000747-Ha
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 04:31:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45229)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtCSv-000742-9r
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 04:31:21 -0500
Message-ID: <54744C64.8000908@redhat.com>
Date: Tue, 25 Nov 2014 10:31:16 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1414478736-30064-1-git-send-email-famz@redhat.com>
	<1414478736-30064-2-git-send-email-famz@redhat.com>
	<547447ED.9030708@redhat.com>
	<20141125092125.GA4641@noname.redhat.com>
	<54744A2B.8060708@redhat.com>
	<20141125093021.GB4641@noname.redhat.com>
In-Reply-To: <20141125093021.GB4641@noname.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Speed up make check-block
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>

On 2014-11-25 at 10:30, Kevin Wolf wrote:
> Am 25.11.2014 um 10:21 hat Max Reitz geschrieben:
>> On 2014-11-25 at 10:21, Kevin Wolf wrote:
>>> Am 25.11.2014 um 10:12 hat Max Reitz geschrieben:
>>>> On 2014-10-28 at 07:45, Fam Zheng wrote:
>>>>> Using /tmp (usually mounted as tmpfs) and cache=writeback, the quick
>>>>> group can be quicker.
>>>>>
>>>>> On my laptop (Lenovo T430s with Fedora 20), this reduces the time from
>>>>> 50s to 30s.
>>>>>
>>>>> Signed-off-by: Fam Zheng <famz@redhat.com>
>>>>> ---
>>>>>   tests/qemu-iotests-quick.sh | 2 +-
>>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/tests/qemu-iotests-quick.sh b/tests/qemu-iotests-quick.sh
>>>>> index 12af731..0b54dbf 100755
>>>>> --- a/tests/qemu-iotests-quick.sh
>>>>> +++ b/tests/qemu-iotests-quick.sh
>>>>> @@ -3,6 +3,6 @@
>>>>>   cd tests/qemu-iotests
>>>>>   ret=0
>>>>> -./check -T -qcow2 -g quick || ret=1
>>>>> +TEST_DIR=/tmp/qemu-iotests-quick-$$ ./check -T -qcow2 -g quick -c writeback || ret=1
>>>> There are (at least) two tests which don't work with -c writeback
>>>> (026 and 039), one of them is in the quick group (039). Why not use
>>>> -c writethrough? It doesn't make any difference on tmpfs anyway  (we
>>>> can't omit it because that will break 091).
>>> Why use any -c? The default is the fast option writeback, and for those
>>> test cases that don't support writeback, something working is chosen
>>> instead.
>> Because that breaks 091.
> That's unfortunate. I wish tmpfs supported O_DIRECT...
>
> But let's just remove it from quick then - it doesn't really matter if
> it doesn't run because of the cache mode or because we didn't include it
> in the group.

Fine with me.

Max

> -c writethrough is okay as long as you really have tmpfs on your /tmp,
> but it really hurts when you don't (and I for one don't, standard RHEL 7
> installation).