From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtG5J-0001tK-0g for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:23:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtG4y-0003N9-J5 for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:23:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtG4y-0003MV-AY for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:22:52 -0500 Message-ID: <547482A5.1050509@redhat.com> Date: Tue, 25 Nov 2014 14:22:45 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416910178-5088-1-git-send-email-mreitz@redhat.com> <87k32jii7e.fsf@blackfin.pond.sub.org> <54747629.8060709@redhat.com> <87sih7fmd8.fsf@blackfin.pond.sub.org> In-Reply-To: <87sih7fmd8.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] iotests: Fix test 039 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , Fam Zheng , =?ISO-8859-15?Q?Michael_M=FCller?= , Mao Chuan Li , qemu-devel@nongnu.org, Stefan Hajnoczi On 2014-11-25 at 14:20, Markus Armbruster wrote: > Max Reitz writes: > >> On 2014-11-25 at 13:21, Markus Armbruster wrote: >>> Max Reitz writes: >>> >>>> Test 039 used to fail >>> I'm confused: "used to" suggests it doesn't anymore, but you sending a >>> patches strongly suggests something's broken. >> Well, it used to fail before this series. :-P >> >> You're right, this sounds bad. Currently, 039 does fail, at least on >> any system with a /proc/sys/kernel/core_pattern passing the dump to >> another program. After this series, it does no longer. >> >>>> because qemu-io -c abort may generate core dumps >>>> even with ulimit -c 0 (and the output then contains "(core dumped)"). >>> How? >> See the patches[1][2] by Mao Chuan Li. If >> /proc/sys/kernel/core_pattern passes the dump to another program, >> ulimit -c 0 does not matter. >> >> [1] http://lists.nongnu.org/archive/html/qemu-devel/2014-11/msg02092.html >> [2] http://lists.nongnu.org/archive/html/qemu-devel/2014-11/msg02093.html >> >> The problem with those patches is that they require access to >> /proc/sys/kernel/core_pattern. I don't like having to run the iotests >> as root. > To me, this sounds like a case of "doctor, it hurts when I do this". What do you mean? That I don't want the iotests to run as root? Or that I don't want to go the alternative of filtering out the "(core dumped)" message? 039 doesn't need a core dump. abort() generates a core dump. Why are we using abort()? Makes no sense. So don't use it. I can see that people may want to use qemu-io -c abort to generate a core dump, though, which is why I'm not simply replacing the abort() call by raise(SIGKILL). Max