From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtHRc-0000e5-Pg for qemu-devel@nongnu.org; Tue, 25 Nov 2014 09:50:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtHRV-0007G2-7L for qemu-devel@nongnu.org; Tue, 25 Nov 2014 09:50:20 -0500 Message-ID: <5474970E.5030308@redhat.com> Date: Tue, 25 Nov 2014 15:49:50 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416924485-13304-1-git-send-email-mreitz@redhat.com> <1416924485-13304-4-git-send-email-mreitz@redhat.com> <20141125144142.GE4641@noname.redhat.com> In-Reply-To: <20141125144142.GE4641@noname.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/12] block/nfs: Add create_opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-stable@nongnu.org, Peter Lieven , Markus Armbruster , qemu-devel@nongnu.org, Stefan Hajnoczi On 2014-11-25 at 15:41, Kevin Wolf wrote: > Am 25.11.2014 um 15:07 hat Max Reitz geschrieben: >> The nfs protocol driver is capable of creating images, but did not >> specify any creation options. Fix it. >> >> Cc: qemu-stable@nongnu.org >> Signed-off-by: Max Reitz > As you'll respin anyway: Can you mention how this would fail? (I suppose > some segfault when trying to access the options?) I'd have to try, but I guess it actually doesn't fail in most cases because the size option is part of the format drivers options anyway. I can imagine something being broken when doing preallocation in qcow2, though, which makes the qcow2 reset the size option. Max