From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtJra-00035P-6l for qemu-devel@nongnu.org; Tue, 25 Nov 2014 12:25:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtJrU-0008SZ-Lm for qemu-devel@nongnu.org; Tue, 25 Nov 2014 12:25:18 -0500 Message-ID: <5474BB6B.1040607@redhat.com> Date: Tue, 25 Nov 2014 18:24:59 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416935562-7760-1-git-send-email-kwolf@redhat.com> <1416935562-7760-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1416935562-7760-4-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] block: Don't probe for unknown backing file format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: armbru@redhat.com, stefanha@redhat.com, qemu-stable@nongnu.org On 2014-11-25 at 18:12, Kevin Wolf wrote: > If a qcow2 image specifies a backing file format that doesn't correspond > to any format driver that qemu knows, we shouldn't fall back to probing, > but simply error out. > > Not looking up the backing file driver in bdrv_open_backing_file(), but > just filling in the "driver" option if it isn't there moves us closer to > the goal of having everything in QDict options and gets us the error > handling of bdrv_open(), which correctly refuses unknown drivers. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Kevin Wolf > --- > block.c | 7 +++--- > tests/qemu-iotests/114 | 61 ++++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/114.out | 13 ++++++++++ > tests/qemu-iotests/group | 1 + > 4 files changed, 78 insertions(+), 4 deletions(-) > create mode 100755 tests/qemu-iotests/114 > create mode 100644 tests/qemu-iotests/114.out Reviewed-by: Max Reitz