qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] target-i386: add feature flags for CPUID[EAX=0xd, ECX=1]
Date: Tue, 25 Nov 2014 21:02:38 +0100	[thread overview]
Message-ID: <5474E05E.7090509@redhat.com> (raw)
In-Reply-To: <20141125184517.GP3137@thinpad.lan.raisama.net>



On 25/11/2014 19:45, Eduardo Habkost wrote:
>> > +static const char *cpuid_xsave_feature_name[] = {
>> > +    "xsaveopt", "xsavec", "xgetbv1", "xsaves",
> None of the above features introduce any new state that might need to be
> migrated, or will require other changes in QEMU to work, right?
> 
> It looks like they don't introduce any extra state, but if they do, they
> need to be added to unmigratable_flags until migration support is
> implemented.
> 
> If they require other QEMU changes, it would be nice if KVM reported
> them using KVM_CHECK_EXTENSION instead of GET_SUPPORTED_CPUID, so it
> wouldn't break "-cpu host".

No, they don't.

Paolo

  reply	other threads:[~2014-11-25 20:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 17:35 [Qemu-devel] [PATCH] target-i386: add feature flags for CPUID[EAX=0xd, ECX=1] Paolo Bonzini
2014-11-25 18:45 ` Eduardo Habkost
2014-11-25 20:02   ` Paolo Bonzini [this message]
2014-11-26  9:20     ` Paolo Bonzini
2014-11-26 11:40       ` Eduardo Habkost
2014-11-26 12:46         ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5474E05E.7090509@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).