From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtMK6-0005kT-Cu for qemu-devel@nongnu.org; Tue, 25 Nov 2014 15:03:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtMJw-0001Tl-11 for qemu-devel@nongnu.org; Tue, 25 Nov 2014 15:02:54 -0500 Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]:53605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtMJv-0001Td-PP for qemu-devel@nongnu.org; Tue, 25 Nov 2014 15:02:43 -0500 Received: by mail-wg0-f46.google.com with SMTP id x12so1857480wgg.5 for ; Tue, 25 Nov 2014 12:02:43 -0800 (PST) Sender: Paolo Bonzini Message-ID: <5474E05E.7090509@redhat.com> Date: Tue, 25 Nov 2014 21:02:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1416936942-32516-1-git-send-email-pbonzini@redhat.com> <20141125184517.GP3137@thinpad.lan.raisama.net> In-Reply-To: <20141125184517.GP3137@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-i386: add feature flags for CPUID[EAX=0xd, ECX=1] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 25/11/2014 19:45, Eduardo Habkost wrote: >> > +static const char *cpuid_xsave_feature_name[] = { >> > + "xsaveopt", "xsavec", "xgetbv1", "xsaves", > None of the above features introduce any new state that might need to be > migrated, or will require other changes in QEMU to work, right? > > It looks like they don't introduce any extra state, but if they do, they > need to be added to unmigratable_flags until migration support is > implemented. > > If they require other QEMU changes, it would be nice if KVM reported > them using KVM_CHECK_EXTENSION instead of GET_SUPPORTED_CPUID, so it > wouldn't break "-cpu host". No, they don't. Paolo