From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtOFV-0004mD-Da for qemu-devel@nongnu.org; Tue, 25 Nov 2014 17:06:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtOFQ-0000t8-E0 for qemu-devel@nongnu.org; Tue, 25 Nov 2014 17:06:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtOFQ-0000t2-6I for qemu-devel@nongnu.org; Tue, 25 Nov 2014 17:06:12 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAPM6Bun028195 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 25 Nov 2014 17:06:11 -0500 Message-ID: <5474FD52.2020207@redhat.com> Date: Tue, 25 Nov 2014 15:06:10 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416822200-31088-1-git-send-email-mreitz@redhat.com> <1416822200-31088-6-git-send-email-mreitz@redhat.com> In-Reply-To: <1416822200-31088-6-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="03GQ5sNnbVDxdaC485JVXtEhrCrodXptH" Subject: Re: [Qemu-devel] [PATCH v3 5/5] iotests: Add test for relative backing file names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --03GQ5sNnbVDxdaC485JVXtEhrCrodXptH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/24/2014 02:43 AM, Max Reitz wrote: > Sometimes, qemu does not have a filename to work with, so it does not > know which directory to use for a backing file specified by a relative > filename. Add a test which tests that qemu exits with an appropriate > error message. >=20 > Additionally, add a test for qemu-img create with a backing filename > relative to the backed image's base directory while omitting the image > size. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/110 | 94 ++++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/110.out | 19 ++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 114 insertions(+) > create mode 100755 tests/qemu-iotests/110 > create mode 100644 tests/qemu-iotests/110.out >=20 > +echo > +echo '=3D=3D=3D Backing name is always relative to the backed image =3D= =3D=3D' > +echo > + > +# omit the image size; it shoud work anyway s/shoud/should/ With the typo fix, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --03GQ5sNnbVDxdaC485JVXtEhrCrodXptH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUdP1SAAoJEKeha0olJ0Nqu5AIAJWwVO7frM5hi0i1tQCeQff3 l0kbrYxvyv2V0/zypLF2N0Z5mTMl/uWLrB3kerjlXyZA5/YyNUsvUpjvbBdboOSn Yv+wKQVKAanEJEK70CiMYFF/7RX8r6ZeZ2rt6dQLGf1ytlPKD2Xa9cUasP/Ob7k2 NiN6KmvMTMJAUfCg0IiLRRvAXRZE6pra7DLjjOsfBaXR175qO14fiPDEGWWc6vbk iGAL1Hum40kdKPpWF2rByamxSCgxvrLu4WqgVgcF+DHlkOjAv+NAWLtPfbyfk1Om ZFGU2/syBxdCjH7yvg/naomHPzQCwk0n4V0m4Za3gOpBiFI/nHq9c3r0ce3BpIY= =2u3V -----END PGP SIGNATURE----- --03GQ5sNnbVDxdaC485JVXtEhrCrodXptH--