qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/5] block: JSON filenames and relative backing files
Date: Wed, 26 Nov 2014 10:12:01 +0100	[thread overview]
Message-ID: <54759961.4030306@redhat.com> (raw)
In-Reply-To: <20141126053533.GB9188@fam-t430.nay.redhat.com>

On 2014-11-26 at 06:35, Fam Zheng wrote:
> On Mon, 11/24 10:43, Max Reitz wrote:
>> @@ -1209,7 +1218,13 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict *options, Error **errp)
>>           QDECREF(options);
>>           goto free_exit;
>>       } else {
>> -        bdrv_get_full_backing_filename(bs, backing_filename, PATH_MAX);
>> +        bdrv_get_full_backing_filename(bs, backing_filename, PATH_MAX, &local_err);
> Over 80 charaters?

Oops, will fix, thanks.

Max

  reply	other threads:[~2014-11-26  9:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24  9:43 [Qemu-devel] [PATCH v3 0/5] block: Relative backing files Max Reitz
2014-11-24  9:43 ` [Qemu-devel] [PATCH v3 1/5] block: Get full backing filename from string Max Reitz
2014-11-25 19:53   ` Eric Blake
2014-11-26  5:38   ` Fam Zheng
2014-11-24  9:43 ` [Qemu-devel] [PATCH v3 2/5] block: JSON filenames and relative backing files Max Reitz
2014-11-25 19:57   ` Eric Blake
2014-11-26  9:10     ` Max Reitz
2014-11-26  5:35   ` Fam Zheng
2014-11-26  9:12     ` Max Reitz [this message]
2014-11-24  9:43 ` [Qemu-devel] [PATCH v3 3/5] block: Relative backing file for image creation Max Reitz
2014-11-25 20:11   ` Eric Blake
2014-11-26  5:40   ` Fam Zheng
2014-11-24  9:43 ` [Qemu-devel] [PATCH v3 4/5] block/vmdk: Relative backing file for creation Max Reitz
2014-11-25 21:52   ` Eric Blake
2014-11-26  5:38   ` Fam Zheng
2014-11-24  9:43 ` [Qemu-devel] [PATCH v3 5/5] iotests: Add test for relative backing file names Max Reitz
2014-11-25 22:06   ` Eric Blake
2014-11-26  9:24     ` Max Reitz
2014-11-26  5:45   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54759961.4030306@redhat.com \
    --to=mreitz@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).