From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32975)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtYdx-0004oJ-Lg
	for qemu-devel@nongnu.org; Wed, 26 Nov 2014 04:12:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtYdo-000728-29
	for qemu-devel@nongnu.org; Wed, 26 Nov 2014 04:12:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46227)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtYdn-000723-RF
	for qemu-devel@nongnu.org; Wed, 26 Nov 2014 04:12:03 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAQ9C3d6014854
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 26 Nov 2014 04:12:03 -0500
Message-ID: <54759961.4030306@redhat.com>
Date: Wed, 26 Nov 2014 10:12:01 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1416822200-31088-1-git-send-email-mreitz@redhat.com>
	<1416822200-31088-3-git-send-email-mreitz@redhat.com>
	<20141126053533.GB9188@fam-t430.nay.redhat.com>
In-Reply-To: <20141126053533.GB9188@fam-t430.nay.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/5] block: JSON filenames and relative
 backing files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 2014-11-26 at 06:35, Fam Zheng wrote:
> On Mon, 11/24 10:43, Max Reitz wrote:
>> @@ -1209,7 +1218,13 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict *options, Error **errp)
>>           QDECREF(options);
>>           goto free_exit;
>>       } else {
>> -        bdrv_get_full_backing_filename(bs, backing_filename, PATH_MAX);
>> +        bdrv_get_full_backing_filename(bs, backing_filename, PATH_MAX, &local_err);
> Over 80 charaters?

Oops, will fix, thanks.

Max