From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtYpX-0001kM-Ge for qemu-devel@nongnu.org; Wed, 26 Nov 2014 04:24:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtYpR-0002LT-BA for qemu-devel@nongnu.org; Wed, 26 Nov 2014 04:24:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtYpR-0002LP-2I for qemu-devel@nongnu.org; Wed, 26 Nov 2014 04:24:05 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAQ9O4nF018844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 26 Nov 2014 04:24:04 -0500 Message-ID: <54759C32.1040301@redhat.com> Date: Wed, 26 Nov 2014 10:24:02 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416822200-31088-1-git-send-email-mreitz@redhat.com> <1416822200-31088-6-git-send-email-mreitz@redhat.com> <5474FD52.2020207@redhat.com> In-Reply-To: <5474FD52.2020207@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 5/5] iotests: Add test for relative backing file names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 2014-11-25 at 23:06, Eric Blake wrote: > On 11/24/2014 02:43 AM, Max Reitz wrote: >> Sometimes, qemu does not have a filename to work with, so it does not >> know which directory to use for a backing file specified by a relative >> filename. Add a test which tests that qemu exits with an appropriate >> error message. >> >> Additionally, add a test for qemu-img create with a backing filename >> relative to the backed image's base directory while omitting the image >> size. >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/110 | 94 ++++++++++++++++++++++++++++++++++++++++++++++ >> tests/qemu-iotests/110.out | 19 ++++++++++ >> tests/qemu-iotests/group | 1 + >> 3 files changed, 114 insertions(+) >> create mode 100755 tests/qemu-iotests/110 >> create mode 100644 tests/qemu-iotests/110.out >> >> +echo >> +echo '=== Backing name is always relative to the backed image ===' >> +echo >> + >> +# omit the image size; it shoud work anyway > s/shoud/should/ As I did the same mistake twice in some other series, I'm beginning to want to blame my keyboard... (I know that certain key sequences work bad, for instance, the U in NULL is sometimes omitted (not in null, only in NULL)) Max > With the typo fix, > Reviewed-by: Eric Blake