From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtZek-0003Kg-9E for qemu-devel@nongnu.org; Wed, 26 Nov 2014 05:17:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtZeZ-0002Du-Eq for qemu-devel@nongnu.org; Wed, 26 Nov 2014 05:17:06 -0500 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:55224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtZeZ-0002DW-5o for qemu-devel@nongnu.org; Wed, 26 Nov 2014 05:16:55 -0500 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Nov 2014 10:16:53 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id D37EC2190045 for ; Wed, 26 Nov 2014 10:16:22 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sAQAGo0r16646454 for ; Wed, 26 Nov 2014 10:16:50 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sAQAGnWp016084 for ; Wed, 26 Nov 2014 03:16:50 -0700 Message-ID: <5475A890.5060705@linux.vnet.ibm.com> Date: Wed, 26 Nov 2014 13:16:48 +0300 From: Ekaterina Tumanova MIME-Version: 1.0 References: <1416392276-10408-1-git-send-email-tumanova@linux.vnet.ibm.com> <20141125130115.GD21126@stefanha-thinkpad.redhat.com> In-Reply-To: <20141125130115.GD21126@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, borntraeger@de.ibm.com, Public KVM Mailing List , armbru@redhat.com, dahi@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, mihajlov@linux.vnet.ibm.com On 11/25/2014 04:01 PM, Stefan Hajnoczi wrote: > On Wed, Nov 19, 2014 at 11:17:50AM +0100, Ekaterina Tumanova wrote: >> Hi folks, >> >> I'm sorry for the recent spam. I messed up during code submission last time. >> So please ignore any previous notes you received from me and answer only to >> this thread. >> >> This is the rework of the geometry+blocksize patch, which was >> recently discussed here: >> http://lists.gnu.org/archive/html/qemu-devel/2014-11/msg01148.html >> >> Markus suggested that we only detect blocksize and geometry for DASDs. >> >> According to this agreement new version contains DASD special casing. >> The driver methods are implemented only for "host_device" and inner hdev_xxx >> functions check if the backing storage is a DASD by means of >> BIODASDINFO2 ioctl. >> >> Original patchset can be found here: >> http://lists.gnu.org/archive/html/qemu-devel/2014-07/msg03791.html > > This is description is mainly a changelog. Links to previous email > threads are useful for additional info but please include a > self-contained description of the series and the rationale behind it. > will include into the next version > Comments: > > 1. This series overrides the logical_block_size and > physical_block_size options for raw images on DASD devices. Users > expect their command-line options to be honored, so the options > should not be overriden if they have been given on the command-line. > will fix that > 2. Only virtio_blk is modified, this is inconsistent. All emulated > storage controllers using BlockConf have the same block size > probing behavior. I will add blkconf_blocksizes call to other BlockConf users. > > 3. Why does s390 need to customize hd_geometry_guess()? > Since hd_geometry_guess contains semantics of x86-specific LBA translation, we have to modify it not to get in the way of z architecture > 4. Please use scripts/checkpatch.pl to check coding style. > I did :) Thanks a lot, Kate.