From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtc4X-0004FV-23 for qemu-devel@nongnu.org; Wed, 26 Nov 2014 07:51:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xtc4P-0007lY-6P for qemu-devel@nongnu.org; Wed, 26 Nov 2014 07:51:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtc4O-0007lK-VQ for qemu-devel@nongnu.org; Wed, 26 Nov 2014 07:51:45 -0500 Message-ID: <5475CCCF.8090106@redhat.com> Date: Wed, 26 Nov 2014 13:51:27 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20141126103841.7772.11864.stgit@PASHA-ISP> <20141126104038.7772.79661.stgit@PASHA-ISP> <5475B102.6060904@redhat.com> <000b01d00973$a6e63c60$f4b2b520$@Dovgaluk@ispras.ru> In-Reply-To: <000b01d00973$a6e63c60$f4b2b520$@Dovgaluk@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v5 20/31] replay: recording and replaying clock ticks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com On 26/11/2014 13:22, Pavel Dovgaluk wrote: >> > Any reason to do this instead of using REPLAY_CLOCK in qemu_get_clock, >> > like you do for QEMU_CLOCK_VIRTUAL_RT? > hw/ppc.c uses this functions in pre_save and post_load function. > It seems that these calls' results also should be logged by replay. It should use qemu_get_clock_ns(QEMU_CLOCK_REALTIME) instead; same for block/raw-posix.c and target-mips/kvm.c. Paolo