From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59515)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1XtcSn-0003Gc-Oe
	for qemu-devel@nongnu.org; Wed, 26 Nov 2014 08:17:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1XtcSf-0006qI-NZ
	for qemu-devel@nongnu.org; Wed, 26 Nov 2014 08:16:57 -0500
Received: from relay.parallels.com ([195.214.232.42]:56540)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1XtcSf-0006q4-FV
	for qemu-devel@nongnu.org; Wed, 26 Nov 2014 08:16:49 -0500
Message-ID: <5475D2AF.2050803@openvz.org>
Date: Wed, 26 Nov 2014 16:16:31 +0300
From: "Denis V. Lunev" <den@openvz.org>
MIME-Version: 1.0
References: <1416996685-15115-1-git-send-email-den@openvz.org>	<1416996685-15115-2-git-send-email-den@openvz.org>
	<20141126132755.1cf2a019.cornelia.huck@de.ibm.com>
In-Reply-To: <20141126132755.1cf2a019.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] balloon: call
 qdev_alias_all_properties for proxy dev in balloon class init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Raushaniya Maksudova <rmaksudova@parallels.com>, Anthony Liguori <aliguori@amazon.com>

On 26/11/14 15:27, Cornelia Huck wrote:
> On Wed, 26 Nov 2014 13:11:24 +0300
> "Denis V. Lunev" <den@openvz.org> wrote:
>
>> From: Raushaniya Maksudova <rmaksudova@parallels.com>
>>
>> The idea is that all other virtio devices are calling this helper
>> to merge properties of the proxy device. This is the only difference
>> in between this helper and code in inside virtio_instance_init_common.
>> The patch should not cause any harm as property list in generic balloon
>> code is empty.
>>
>> This also allows to avoid some dummy errors like fixed by this
>>      commit 91ba21208839643603e7f7fa5864723c3f371ebe
>>      Author: Gonglei <arei.gonglei@huawei.com>
>>      Date:   Tue Sep 30 14:10:35 2014 +0800
>>      virtio-balloon: fix virtio-balloon child refcount in transports
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> Acked-by: Raushaniya Maksudova <rmaksudova@parallels.com>
>> CC: Cornelia Huck <cornelia.huck@de.ibm.com>
>> CC: Christian Borntraeger <borntraeger@de.ibm.com>
>> CC: Anthony Liguori <aliguori@amazon.com>
>> CC: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>   hw/s390x/virtio-ccw.c  | 5 ++---
>>   hw/virtio/virtio-pci.c | 5 ++---
>>   2 files changed, 4 insertions(+), 6 deletions(-)
> Shouldn't this have the sign-off of the author (rather than the ack) as
> well?
>
> Otherwise, looks sane.
>
I am an original author of the patch and prepared it to Rushana
to pass command line options for her next patch. I'll fix this
line in the next submission.