From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55670)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XtfYq-0007YP-8R
	for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:35:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XtfYk-0006Xv-DB
	for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:35:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35453)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XtfYk-0006Xm-28
	for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:35:18 -0500
Message-ID: <5476013F.6070503@redhat.com>
Date: Wed, 26 Nov 2014 09:35:11 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1416487488-8423-1-git-send-email-mreitz@redhat.com>
	<1416487488-8423-4-git-send-email-mreitz@redhat.com>
In-Reply-To: <1416487488-8423-4-git-send-email-mreitz@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="9M0qAQJ0sAUed9KvmgmoqCwoMfWfWBlKW"
Subject: Re: [Qemu-devel] [PATCH 3/3] hmp: Expose read-only option for
	'change'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--9M0qAQJ0sAUed9KvmgmoqCwoMfWfWBlKW
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 11/20/2014 05:44 AM, Max Reitz wrote:
> Expose the new read-only option of qmp_change_blockdev() for the
> 'change' HMP command.
>=20
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  hmp-commands.hx | 24 +++++++++++++++++++++---
>  hmp.c           | 17 ++++++++++++++++-
>  2 files changed, 37 insertions(+), 4 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Even if you go with my suggestion of a new QMP command in 2/3, I'm just
fine with extending the existing HMP command without adding a new name
(although this patch would then have to be modified to call into the new
QMP command as appropriate).

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--9M0qAQJ0sAUed9KvmgmoqCwoMfWfWBlKW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg

iQEcBAEBCAAGBQJUdgE/AAoJEKeha0olJ0NqrLUIAIvRJqBj1tcPL8ji0BX9XCeq
+oAnQ59aLeNZ7HgqStz/CPDRZuM43Dh32fFeq9E18405/jq2n30mtAQ+HaQXhPE4
+xB5S2EU+6Xmv8zz0TfDqGfL0USnrKCt1dvaLsIoLaK1ul0XbtN+r/mDzi7gjMxz
dcMaRqOq2zjSrGhQZkI3j2ZlOyVY9kcTJ4Mz1BkFD74WEBzpSBV1EviXubOxvUql
g3JeyQLSSbYn2PoZxdEit7Yo+q2GRXd9FIa3QQ4ir41nh8MT7KXI7swoFAZ/VBuS
tg6fmSHlpsTzb4k1C40jlu6Uc+D+Mc57FDmy3pClGwYoGJplGMqFfAROIceS5a4=
=j49u
-----END PGP SIGNATURE-----

--9M0qAQJ0sAUed9KvmgmoqCwoMfWfWBlKW--