From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtfce-0001if-Co for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:39:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtfcZ-0008Gz-F2 for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:39:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtfcZ-0008Gv-6S for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:39:15 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAQGdETN007523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 26 Nov 2014 11:39:14 -0500 Message-ID: <54760231.9070004@redhat.com> Date: Wed, 26 Nov 2014 09:39:13 -0700 From: Eric Blake MIME-Version: 1.0 References: <1417018829-15002-1-git-send-email-mreitz@redhat.com> <1417018829-15002-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1417018829-15002-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Gd0mNNciCMqI3cUDPCoai5Miqj7iX49KF" Subject: Re: [Qemu-devel] [PATCH v4 1/6] checkpatch: Brace handling on multi-line condition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Gd0mNNciCMqI3cUDPCoai5Miqj7iX49KF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/26/2014 09:20 AM, Max Reitz wrote: > CODING_STYLE states the following about braces around blocks: >=20 >> The opening brace is on the line that contains the control flow >> statement that introduces the new block; [...] >=20 > This is obviously impossible with multi-line conditions. Therefore, > CODING_STYLE does not make any clear statement about where to put the > opening brace after a multi-line condition. I'll leave review of this one to others (personally, I'm 80:20 against applying it, but my vote is very weak if you scale it by the percentage of actual C code contributions existing in the tree under my name - so I'll live with majority rules). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Gd0mNNciCMqI3cUDPCoai5Miqj7iX49KF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUdgIxAAoJEKeha0olJ0NqHfYH/R7L0XwPjvq5oCXaZSjBjDDz yNjKER4QoVuPSh5zhMLwkB2NFvCer0/0RQBol28YfRvKBbJ//GvSBe2ydAp/Zcjj Jn5PCDPJfX1XpFwzOWMA4BNWMUsuAVL6oY+Awj3PsYyHo8k+CC3r5M3o3S1H/4/H 0Y2hI6kCtCP9bfjYSb6TtIxR+p/zzweyin1GDsyD+y+vFodhtpn9xkazVvZjUvy6 It1lnDlZoxsIRp8GhvpUDLLKW9bNrx1GRu/9bU0vqcXfA4xdyUjwyhg6Grov1n4w 25ciJJ2i1c3vhrydQJFNj5y8J47T2VGa47/3K+xa8Oh7MLIxrsApB3+1gwMIMe4= =CnCf -----END PGP SIGNATURE----- --Gd0mNNciCMqI3cUDPCoai5Miqj7iX49KF--