From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtfdd-0002gT-07 for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:40:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtfdY-0000CT-2p for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:40:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtfdX-0000CN-Qn for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:40:16 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAQGeFh7005996 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 26 Nov 2014 11:40:15 -0500 Message-ID: <5476026E.2060904@redhat.com> Date: Wed, 26 Nov 2014 09:40:14 -0700 From: Eric Blake MIME-Version: 1.0 References: <1417018829-15002-1-git-send-email-mreitz@redhat.com> <1417018829-15002-4-git-send-email-mreitz@redhat.com> In-Reply-To: <1417018829-15002-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KmlVl7a2LwDha9Qh3IJGIjJGpIslwQKn2" Subject: Re: [Qemu-devel] [PATCH v4 3/6] block: JSON filenames and relative backing files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KmlVl7a2LwDha9Qh3IJGIjJGpIslwQKn2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/26/2014 09:20 AM, Max Reitz wrote: > When using a relative backing file name, qemu needs to know the > directory of the top image file. For JSON filenames, such a directory > cannot be easily determined (e.g. how do you determine the directory of= > a qcow2 BDS directly on top of a quorum BDS?). Therefore, do not allow > relative filenames for the backing file of BDSs only having a JSON > filename. >=20 > Furthermore, BDS::exact_filename should be used whenever possible. If > BDS::filename is not equal to BDS::exact_filename, the former will > always be a JSON object. >=20 > Signed-off-by: Max Reitz > --- > block.c | 28 ++++++++++++++++++++++------ > block/qapi.c | 7 ++++++- > include/block/block.h | 5 +++-- > 3 files changed, 31 insertions(+), 9 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KmlVl7a2LwDha9Qh3IJGIjJGpIslwQKn2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUdgJuAAoJEKeha0olJ0NqQqMH/3Xxc1P0qZU2NPyqO/fslGXy Xpht/F24SXVAPEyYpX72ZUigMdRrFx6sL8LotSsolRKxo+UmVmQITyNqYDkozjEJ avLBYR+0vxgOrHpMNt1zJqy/wAox8uTbKgmdTfuoQIKjnz+TtVXJAd3MkD0aWIc7 wxBan79HhkQjWsf+t/BlLqcLU/FMy07qEomBuE2DgDE0JZ57kbt9EwUUcVtLEn5N bBo75i1cNfLv8LkMhG0n8aOeNIMSrncQNoqvi0whRQOVJmdKh2eBa/739sIovT/Y Yu7bxuFZqwFAzN6Kf4Dtr8SJEJq+d1MXxE/hH2WWcdbPiTDS4GRxIoUmYFIC0No= =SuDI -----END PGP SIGNATURE----- --KmlVl7a2LwDha9Qh3IJGIjJGpIslwQKn2--