From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59357)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtvPV-0005zM-Te
	for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:30:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtvPP-0002La-Ol
	for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:30:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58861)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XtvPP-0002JG-Gq
	for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:30:43 -0500
Message-ID: <5476EF39.9010700@redhat.com>
Date: Thu, 27 Nov 2014 10:30:33 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1415875021-15248-1-git-send-email-maochuan@linux.vnet.ibm.com>
In-Reply-To: <1415875021-15248-1-git-send-email-maochuan@linux.vnet.ibm.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 RFC 0/9] Update tests/qemu-iotests cases
 for multi-platform support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mao Chuan Li <maochuan@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Michael Mueller <mimu@linux.vnet.ibm.com>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>

On 2014-11-13 at 11:36, Mao Chuan Li wrote:
> Currently the qemu-iotest framework is focused on the x86 platform. The suite should be usable by other platforms as well.
> To enable multi-platform usage, this patch set enhances the framework scripts to address this. By using the default machine
> type of the platform one can add specific output files if it deviates from the default. Secondly, single test cases can
> be adjusted as well when e.g. devices have different names or are not supported at all.
>
> Mao Chuan Li (9):
>    qemu-iotests: run qemu with -nodefaults
>    qemu-iotests: qemu machine type support
>    qemu-iotests: add core_pattern access functions
>    qemu-iotests: fix test 039

>    qemu-iotests: s390x: fix test 071
>    qemu-iotests: s390x: fix test 087

To me, the main difference between the current test output and the new 
s390-specific seems to be lines about CD and floppy disk; due to patch 
1, they are gone from x86 as well, though. Therefore, we don't need 
special s390 output, but need to apply the changes directly to 071.out 
and 087.out.

Furthermore, after patch 1, tests 067 and 091 fail for me on x86, too. I 
don't know why 091 fails, but 067 fails because CD and floppy are 
missing from the block-query result and the DEVICE_TRAY_MOVED events are 
missing from QMP output in general (which is completely fine, we just 
need to adjust the reference output accordingly).

Max

>    qemu-iotests: s390x: fix test 041
>    qemu-iotests: s390x: fix test 055
>    qemu-iotests: s390x: fix test 051