From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtvUi-0008H1-AB for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:36:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtvUc-0004Xz-1G for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:36:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtvUb-0004Xn-QQ for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:36:05 -0500 Message-ID: <5476F081.3070806@redhat.com> Date: Thu, 27 Nov 2014 10:36:01 +0100 From: Max Reitz MIME-Version: 1.0 References: <1417023715-18210-1-git-send-email-jsnow@redhat.com> <1417023715-18210-2-git-send-email-jsnow@redhat.com> In-Reply-To: <1417023715-18210-2-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 01/10] qapi: Add optional field "name" to block dirty bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Fam Zheng , armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, pbonzini@redhat.com On 2014-11-26 at 18:41, John Snow wrote: > From: Fam Zheng > > This field will be set for user created dirty bitmap. Also pass in an > error pointer to bdrv_create_dirty_bitmap, so when a name is already > taken on this BDS, it can report an error message. This is not global > check, two BDSes can have dirty bitmap with a common name. > > Implemented bdrv_find_dirty_bitmap to find a dirty bitmap by name, will > be used later when other QMP commands want to reference dirty bitmap by > name. > > Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap. > > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > --- > block-migration.c | 2 +- > block.c | 32 +++++++++++++++++++++++++++++++- > block/mirror.c | 2 +- > include/block/block.h | 7 ++++++- > qapi/block-core.json | 4 +++- > 5 files changed, 42 insertions(+), 5 deletions(-) You can keep R-bs on patches which you don't have modified (or only contextually, or directly according to what the reviewer made a condition for the R-b). Just add them below the S-o-b in the commit message. Reviewed-by: Max Reitz