From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtva3-0001OX-9b for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:41:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtvZw-0006ja-B1 for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:41:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtvZw-0006jQ-2B for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:41:36 -0500 Message-ID: <5476F1CB.5070306@redhat.com> Date: Thu, 27 Nov 2014 10:41:31 +0100 From: Max Reitz MIME-Version: 1.0 References: <1417023715-18210-1-git-send-email-jsnow@redhat.com> <1417023715-18210-3-git-send-email-jsnow@redhat.com> In-Reply-To: <1417023715-18210-3-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Fam Zheng , armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, pbonzini@redhat.com On 2014-11-26 at 18:41, John Snow wrote: > From: Fam Zheng > > The new command pair is added to manage user created dirty bitmap. The > dirty bitmap's name is mandatory and must be unique for the same device, > but different devices can have bitmaps with the same names. > > The granularity is an optional field. If it is not specified, we will > choose a default granularity based on the cluster size if available, > clamped to between 4K and 64K (To mirror how the 'mirror' code was > already choosing granularity.) If we do not have cluster size info Maybe swap the right parenthesis and the full stop? > available, we choose 64K. This code has been factored out into helper Naturally you're better at English than me, but shouldn't this be "into a helper"? > shared with block/mirror. > > The types added to block-core.json will be re-used in future patches > in this series, see: > 'qapi: Add transaction support to block-dirty-bitmap-{add, enable, disable}' > > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > --- > block.c | 19 ++++++++++++++++++ > block/mirror.c | 10 +--------- > blockdev.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++ > include/block/block.h | 1 + > qapi/block-core.json | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 49 +++++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 179 insertions(+), 9 deletions(-) Anyway, with or without these minor changes: Reviewed-by: Max Reitz