qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Mao Chuan Li <maochuan@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Michael Mueller <mimu@linux.vnet.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v1 RFC 0/9] Update tests/qemu-iotests cases for multi-platform support
Date: Thu, 27 Nov 2014 10:45:16 +0100	[thread overview]
Message-ID: <5476F2AC.1030505@redhat.com> (raw)
In-Reply-To: <5476EF39.9010700@redhat.com>

On 2014-11-27 at 10:30, Max Reitz wrote:
> On 2014-11-13 at 11:36, Mao Chuan Li wrote:
>> Currently the qemu-iotest framework is focused on the x86 platform. 
>> The suite should be usable by other platforms as well.
>> To enable multi-platform usage, this patch set enhances the framework 
>> scripts to address this. By using the default machine
>> type of the platform one can add specific output files if it deviates 
>> from the default. Secondly, single test cases can
>> be adjusted as well when e.g. devices have different names or are not 
>> supported at all.
>>
>> Mao Chuan Li (9):
>>    qemu-iotests: run qemu with -nodefaults
>>    qemu-iotests: qemu machine type support
>>    qemu-iotests: add core_pattern access functions
>>    qemu-iotests: fix test 039
>
>>    qemu-iotests: s390x: fix test 071
>>    qemu-iotests: s390x: fix test 087
>
> To me, the main difference between the current test output and the new 
> s390-specific seems to be lines about CD and floppy disk; due to patch 
> 1, they are gone from x86 as well, though. Therefore, we don't need 
> special s390 output, but need to apply the changes directly to 071.out 
> and 087.out.
>
> Furthermore, after patch 1, tests 067 and 091 fail for me on x86, too. 
> I don't know why 091 fails, but 067 fails because CD and floppy are 
> missing from the block-query result and the DEVICE_TRAY_MOVED events 
> are missing from QMP output in general (which is completely fine, we 
> just need to adjust the reference output accordingly).

Ah, I know why 091 failed. I forgot -c writethrough and ran it in /tmp. 
My bad. So it's only 067 that needs fixing.

Max

  reply	other threads:[~2014-11-27  9:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13 10:36 [Qemu-devel] [PATCH v1 RFC 0/9] Update tests/qemu-iotests cases for multi-platform support Mao Chuan Li
2014-11-13 10:36 ` [Qemu-devel] [PATCH v1 RFC 1/9] qemu-iotests: run qemu with -nodefaults Mao Chuan Li
2014-11-13 10:36 ` [Qemu-devel] [PATCH v1 RFC 2/9] qemu-iotests: qemu machine type support Mao Chuan Li
2014-11-13 10:36 ` [Qemu-devel] [PATCH v1 RFC 3/9] qemu-iotests: add core_pattern access functions Mao Chuan Li
2014-11-13 10:36 ` [Qemu-devel] [PATCH v1 RFC 4/9] qemu-iotests: fix test 039 Mao Chuan Li
2014-11-13 15:54   ` Max Reitz
2014-11-25 18:07   ` Michael Mueller
2014-11-13 10:36 ` [Qemu-devel] [PATCH v1 RFC 5/9] qemu-iotests: s390x: fix test 071 Mao Chuan Li
2014-11-13 10:36 ` [Qemu-devel] [PATCH v1 RFC 6/9] qemu-iotests: s390x: fix test 087 Mao Chuan Li
2014-11-13 10:36 ` [Qemu-devel] [PATCH v1 RFC 7/9] qemu-iotests: s390x: fix test 041 Mao Chuan Li
2014-11-13 10:37 ` [Qemu-devel] [PATCH v1 RFC 8/9] qemu-iotests: s390x: fix test 055 Mao Chuan Li
2014-11-13 10:37 ` [Qemu-devel] [PATCH v1 RFC 9/9] qemu-iotests: s390x: fix test 051 Mao Chuan Li
2014-11-27  9:30 ` [Qemu-devel] [PATCH v1 RFC 0/9] Update tests/qemu-iotests cases for multi-platform support Max Reitz
2014-11-27  9:45   ` Max Reitz [this message]
2014-11-27 11:08   ` Michael Mueller
2014-11-27 11:27     ` Kevin Wolf
2014-11-27 13:34       ` Michael Mueller
2014-11-27 14:03         ` Kevin Wolf
2014-11-27 14:09           ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5476F2AC.1030505@redhat.com \
    --to=mreitz@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=maochuan@linux.vnet.ibm.com \
    --cc=mimu@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).