From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtvdk-0006CT-Jg for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:45:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xtvdd-0008SJ-Ge for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:45:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtvdd-0008Rt-8R for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:45:25 -0500 Message-ID: <5476F2AC.1030505@redhat.com> Date: Thu, 27 Nov 2014 10:45:16 +0100 From: Max Reitz MIME-Version: 1.0 References: <1415875021-15248-1-git-send-email-maochuan@linux.vnet.ibm.com> <5476EF39.9010700@redhat.com> In-Reply-To: <5476EF39.9010700@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 RFC 0/9] Update tests/qemu-iotests cases for multi-platform support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mao Chuan Li , qemu-devel@nongnu.org Cc: Kevin Wolf , Michael Mueller , Alexander Graf , Christian Borntraeger , Stefan Hajnoczi , Cornelia Huck On 2014-11-27 at 10:30, Max Reitz wrote: > On 2014-11-13 at 11:36, Mao Chuan Li wrote: >> Currently the qemu-iotest framework is focused on the x86 platform. >> The suite should be usable by other platforms as well. >> To enable multi-platform usage, this patch set enhances the framework >> scripts to address this. By using the default machine >> type of the platform one can add specific output files if it deviates >> from the default. Secondly, single test cases can >> be adjusted as well when e.g. devices have different names or are not >> supported at all. >> >> Mao Chuan Li (9): >> qemu-iotests: run qemu with -nodefaults >> qemu-iotests: qemu machine type support >> qemu-iotests: add core_pattern access functions >> qemu-iotests: fix test 039 > >> qemu-iotests: s390x: fix test 071 >> qemu-iotests: s390x: fix test 087 > > To me, the main difference between the current test output and the new > s390-specific seems to be lines about CD and floppy disk; due to patch > 1, they are gone from x86 as well, though. Therefore, we don't need > special s390 output, but need to apply the changes directly to 071.out > and 087.out. > > Furthermore, after patch 1, tests 067 and 091 fail for me on x86, too. > I don't know why 091 fails, but 067 fails because CD and floppy are > missing from the block-query result and the DEVICE_TRAY_MOVED events > are missing from QMP output in general (which is completely fine, we > just need to adjust the reference output accordingly). Ah, I know why 091 failed. I forgot -c writethrough and ran it in /tmp. My bad. So it's only 067 that needs fixing. Max