From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>, Ming Lei <ming.lei@canonical.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 1/3] linux-aio: fix submit aio as a batch
Date: Thu, 27 Nov 2014 17:58:26 +0100 [thread overview]
Message-ID: <54775832.1080205@redhat.com> (raw)
In-Reply-To: <20141127165652.GN15586@stefanha-thinkpad.lan>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 27/11/2014 17:56, Stefan Hajnoczi wrote:
> I am asking for a one-line if statement to avoid introducing a
> subtle assumption that would be a pain to debug in the future.
> It's so easy to add that I'm against merging the patch without this
> protection.
Yeah, either that or an assertion must be there.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJUd1guAAoJEL/70l94x66DfR8H/1De/j4oEmPA1XKSguoXtJz+
vjMzSg93cfpE4e095LqQ7Ho7imSxWuSNPf7vT6NBM0jRTebBTwMk224NCp1IkCYv
U9nFCo3aJsRizSlDO4AjUJv55AsGUJXlo/gjXwwYPBcbn4lC3GV2MNCcZi/rAfMe
FGPozxARBqT+6BD200meRsrIbsGvLjQXwCgWsDpb5OuxBM3tB7amJQNIIG9GI0uI
YTTn1Vtn7E2lsYKNu4Rv2yL6Lg6zAkJizZWMBk1uJI9WzdFpbb+tarQKI0nrsB3D
4SXAhyAGTkFmvNpWwoFQLHd9hWtqUIZzN1n7Vlperj+/O27pKPtJujpl5jGgkc8=
=lXXB
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-11-27 17:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 7:23 [Qemu-devel] [PATCH v6 0/3] linux-aio: fix batch submission Ming Lei
2014-11-25 7:23 ` [Qemu-devel] [PATCH v6 1/3] linux-aio: fix submit aio as a batch Ming Lei
2014-11-25 13:08 ` Stefan Hajnoczi
2014-11-25 14:45 ` Ming Lei
2014-11-25 16:18 ` Stefan Hajnoczi
2014-11-26 9:15 ` Ming Lei
2014-11-27 16:56 ` Stefan Hajnoczi
2014-11-27 16:58 ` Paolo Bonzini [this message]
2014-11-28 3:01 ` Ming Lei
2014-11-26 11:18 ` Kevin Wolf
2014-11-28 2:16 ` Ming Lei
2014-11-26 14:48 ` Kevin Wolf
2014-11-25 7:23 ` [Qemu-devel] [PATCH v6 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case Ming Lei
2014-11-25 13:14 ` Stefan Hajnoczi
2014-11-26 11:27 ` Kevin Wolf
2014-11-28 2:27 ` Ming Lei
2014-11-28 11:26 ` Kevin Wolf
2014-11-25 7:23 ` [Qemu-devel] [PATCH v6 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb' Ming Lei
2014-11-25 13:14 ` Stefan Hajnoczi
2014-11-26 11:28 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54775832.1080205@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).