From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu2nu-0006wr-Mm for qemu-devel@nongnu.org; Thu, 27 Nov 2014 12:24:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xu2no-0000ZE-Ir for qemu-devel@nongnu.org; Thu, 27 Nov 2014 12:24:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu2no-0000ZA-Aj for qemu-devel@nongnu.org; Thu, 27 Nov 2014 12:24:24 -0500 Message-ID: <54775832.1080205@redhat.com> Date: Thu, 27 Nov 2014 17:58:26 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1416900193-3763-1-git-send-email-ming.lei@canonical.com> <1416900193-3763-2-git-send-email-ming.lei@canonical.com> <20141125130804.GE21126@stefanha-thinkpad.redhat.com> <20141125161856.GA22421@stefanha-thinkpad.redhat.com> <20141127165652.GN15586@stefanha-thinkpad.lan> In-Reply-To: <20141127165652.GN15586@stefanha-thinkpad.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 1/3] linux-aio: fix submit aio as a batch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Ming Lei Cc: Kevin Wolf , qemu-devel , Stefan Hajnoczi -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 27/11/2014 17:56, Stefan Hajnoczi wrote: > I am asking for a one-line if statement to avoid introducing a > subtle assumption that would be a pain to debug in the future. > It's so easy to add that I'm against merging the patch without this > protection. Yeah, either that or an assertion must be there. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUd1guAAoJEL/70l94x66DfR8H/1De/j4oEmPA1XKSguoXtJz+ vjMzSg93cfpE4e095LqQ7Ho7imSxWuSNPf7vT6NBM0jRTebBTwMk224NCp1IkCYv U9nFCo3aJsRizSlDO4AjUJv55AsGUJXlo/gjXwwYPBcbn4lC3GV2MNCcZi/rAfMe FGPozxARBqT+6BD200meRsrIbsGvLjQXwCgWsDpb5OuxBM3tB7amJQNIIG9GI0uI YTTn1Vtn7E2lsYKNu4Rv2yL6Lg6zAkJizZWMBk1uJI9WzdFpbb+tarQKI0nrsB3D 4SXAhyAGTkFmvNpWwoFQLHd9hWtqUIZzN1n7Vlperj+/O27pKPtJujpl5jGgkc8= =lXXB -----END PGP SIGNATURE-----