From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu2RD-00009H-I5 for qemu-devel@nongnu.org; Thu, 27 Nov 2014 12:01:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xu2R6-0001PO-W3 for qemu-devel@nongnu.org; Thu, 27 Nov 2014 12:01:03 -0500 Message-ID: <547758B6.3010301@redhat.com> Date: Thu, 27 Nov 2014 18:00:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1417010463-3527-1-git-send-email-pbonzini@redhat.com> <20141127005140.GF17494@thor.bakeyournoodle.com> In-Reply-To: <20141127005140.GF17494@thor.bakeyournoodle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ppc: do not use get_clock_realtime() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 27/11/2014 01:51, Tony Breeds wrote: > On Wed, Nov 26, 2014 at 03:01:01PM +0100, Paolo Bonzini wrote: >> Use the external qemu-timer API instead. > > Perhaps it's obvious but is it reasonable to expand on why you're > doign this in the commit message? You're right. It's just that the API should be private to qemu-timer.c, it is not meant for external usage---and it is messy because get_clock_realtime() is for QEMU_CLOCK_HOST. In addition, all uses of QEMU_CLOCK_HOST should probably use rtc_clock instead, and this patch makes it easier to track those places for a follow-up switch to rtc_clock. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUd1izAAoJEL/70l94x66D8ncH/jwc6oVfUjHvBau3GJy0Vi/I S5kMndpPKgepMlAWWSK67uoMZQWAyRwG4Bwyat3g8RnpevQTN1pLZG276c2f5t5o piB9nGmT7BPhxkEiWGGtxeX5ob1Ab8hhTm4Ai78fH8OnQexBT1B06Oz3zcYZKoGD ckbCzEeiAb8Jxm4wop/s+WApqcnWAsfriCJ0XWUQxtxIbt3esmfMzW+n2fxvhHI1 ookJgqn1ssHpZBYu5lnsPxY+kVTrf0dQaeiPApGSmHUJknmnAEXUGKl1jsdjLCE2 8h5sasf3a7xL+GmZrYjzyZbLYm6BqmjNSsBYCFHYVYVFl857b/S1azoxPC5EZc0= =4+yL -----END PGP SIGNATURE-----