From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuJWu-0006Nu-NB for qemu-devel@nongnu.org; Fri, 28 Nov 2014 06:16:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XuJWl-0003ti-HP for qemu-devel@nongnu.org; Fri, 28 Nov 2014 06:16:04 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:41232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuJWl-0003ta-7t for qemu-devel@nongnu.org; Fri, 28 Nov 2014 06:15:55 -0500 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 28 Nov 2014 11:15:54 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 2CEEF2190063 for ; Fri, 28 Nov 2014 11:15:24 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sASBFpVV20250740 for ; Fri, 28 Nov 2014 11:15:51 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sASBFpq2030160 for ; Fri, 28 Nov 2014 04:15:51 -0700 Message-ID: <54785966.5040208@linux.vnet.ibm.com> Date: Fri, 28 Nov 2014 14:15:50 +0300 From: Ekaterina Tumanova MIME-Version: 1.0 References: <1416392276-10408-1-git-send-email-tumanova@linux.vnet.ibm.com> <20141125130115.GD21126@stefanha-thinkpad.redhat.com> <5475A890.5060705@linux.vnet.ibm.com> <20141128103545.GC11358@stefanha-thinkpad.redhat.com> In-Reply-To: <20141128103545.GC11358@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, borntraeger@de.ibm.com, Public KVM Mailing List , armbru@redhat.com, dahi@linux.vnet.ibm.com, Stefan Hajnoczi , cornelia.huck@de.ibm.com, pbonzini@redhat.com, mihajlov@linux.vnet.ibm.com On 11/28/2014 01:35 PM, Stefan Hajnoczi wrote: > On Wed, Nov 26, 2014 at 01:16:48PM +0300, Ekaterina Tumanova wrote: >> On 11/25/2014 04:01 PM, Stefan Hajnoczi wrote: >>> On Wed, Nov 19, 2014 at 11:17:50AM +0100, Ekaterina Tumanova wrote: >>> 3. Why does s390 need to customize hd_geometry_guess()? >>> >> Since hd_geometry_guess contains semantics of x86-specific LBA translation, >> we have to modify it not to get in the way of z >> architecture > > If the behavior is x86-specific, it should be made x86-specific. z, > ppc, sparc, arm, etc should share the non-x86-specific code path. It's > weird to single out z here, this seems like the wrong way around. > > Is the x86-specific behavior a problem in practice? No one seemed to > mind for the other targets. > on s390 arch this adds support for FCP attached SCSI disks that do not yet have a partition table. Without this patch, fdisk -l on the host would return different results then fdisk -l in the guest. If you guys don't like the way patch goes, I can exclude it from patch series and we can discuss it later. But I thought that since it's related to the hard drive geometry, and since we change hd_geometry_guess in this patchset anyway, why not get rid of this problem as well. Kate.