From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuKr6-0000lM-Bp for qemu-devel@nongnu.org; Fri, 28 Nov 2014 07:41:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XuKr0-0005iC-75 for qemu-devel@nongnu.org; Fri, 28 Nov 2014 07:41:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuKqz-0005i2-W0 for qemu-devel@nongnu.org; Fri, 28 Nov 2014 07:40:54 -0500 Message-ID: <54786D46.3020705@redhat.com> Date: Fri, 28 Nov 2014 13:40:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20141126103841.7772.11864.stgit@PASHA-ISP> <20141126104049.7772.3594.stgit@PASHA-ISP> <5475B3AB.1040402@redhat.com> <002b01d00afe$71142160$533c6420$@Dovgaluk@ispras.ru> In-Reply-To: <002b01d00afe$71142160$533c6420$@Dovgaluk@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v5 22/31] timer: introduce new QEMU_CLOCK_VIRTUAL_RT clock List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com On 28/11/2014 12:28, Pavel Dovgaluk wrote: > Not so easy :) > cpu_get_clock() checks vm_clock_seqlock which is locked in icount_warp_rt(). > And after locking it requests the value of QEMU_CLOCK_VIRTUAL_RT: > > seqlock_write_lock(&timers_state.vm_clock_seqlock); > if (runstate_is_running()) { > int64_t clock = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL_RT); Not so hard :D You can use cpu_get_clock_locked() there. In fact, cpu_get_clock_locked() is already used below in the "if", so we can reuse "clock" instead of the other variable "cur_time". Paolo