From: Peter Lieven <pl@kamp.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net,
ming.lei@canonical.com, armbru@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, pbonzini@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH 1/3] Revert "coroutine: make pool size dynamic"
Date: Fri, 28 Nov 2014 13:45:46 +0100 [thread overview]
Message-ID: <54786E7A.4040105@kamp.de> (raw)
In-Reply-To: <20141128124209.GI13631@stefanha-thinkpad.redhat.com>
Am 28.11.2014 um 13:42 schrieb Stefan Hajnoczi:
> On Thu, Nov 27, 2014 at 11:27:04AM +0100, Peter Lieven wrote:
>> This reverts commit ac2662a913ee5854b1269256adbdc14e57ba480a.
> Justification?
>
> Won't we hit the same problem as the global pool: either pool size is
> too large or too small. If you exceed the pool size performance drops
> dramatically.
Each thread has its own pool. But you can ignore this series I think.
The idea Paolo came up with seems to be better. With
my last improvement it seems to have equal performance without
the drawback of different threads creating and destroying the coroutines.
Peter
next prev parent reply other threads:[~2014-11-28 12:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 10:27 [Qemu-devel] [RFC PATCH 0/3] qemu-coroutine: use a ring per thread for the pool Peter Lieven
2014-11-27 10:27 ` [Qemu-devel] [RFC PATCH 1/3] Revert "coroutine: make pool size dynamic" Peter Lieven
2014-11-28 12:42 ` Stefan Hajnoczi
2014-11-28 12:45 ` Peter Lieven [this message]
2014-11-27 10:27 ` [Qemu-devel] [RFC PATCH 2/3] block/block-backend.c: remove coroutine pool reservation Peter Lieven
2014-11-27 10:27 ` [Qemu-devel] [RFC PATCH 3/3] qemu-coroutine: use a ring per thread for the pool Peter Lieven
2014-11-27 16:40 ` Paolo Bonzini
2014-11-28 8:13 ` Peter Lieven
[not found] ` <54784E55.6060405@redhat.com>
2014-11-28 10:37 ` Peter Lieven
2014-11-28 11:14 ` Paolo Bonzini
2014-11-28 11:21 ` Peter Lieven
2014-11-28 11:23 ` Paolo Bonzini
2014-11-28 11:27 ` Peter Lieven
2014-11-28 11:32 ` Peter Lieven
2014-11-28 11:46 ` Peter Lieven
2014-11-28 12:26 ` Paolo Bonzini
2014-11-28 12:39 ` Peter Lieven
2014-11-28 12:45 ` Paolo Bonzini
2014-11-28 12:49 ` Peter Lieven
2014-11-28 12:56 ` Paolo Bonzini
2014-11-28 13:17 ` Peter Lieven
2014-11-28 14:17 ` Paolo Bonzini
2014-11-28 20:11 ` Peter Lieven
2014-11-28 13:13 ` Peter Lieven
2014-11-28 12:21 ` Paolo Bonzini
2014-11-28 12:26 ` Peter Lieven
2014-11-28 12:40 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54786E7A.4040105@kamp.de \
--to=pl@kamp.de \
--cc=armbru@redhat.com \
--cc=benoit@irqsave.net \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).